Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@sbeigel
Copy link
Contributor

@sbeigel sbeigel commented Mar 24, 2018

WebSocketController has to implement the "new" marker interface PlayController to keep it usable and working.

@asolntsev asolntsev self-assigned this Jun 4, 2018
@asolntsev asolntsev merged commit 57813a0 into playframework:master Jun 4, 2018
@asolntsev
Copy link
Contributor

@sbeigel Thank you for the PR!

@ludofischer
Copy link
Contributor

Is there any possibility of a new Play 1 release with this fix?

@xael-fry
Copy link
Member

@ludovicofischer I will prepare the release for this week

@ludofischer
Copy link
Contributor

@xael-fry That would be awesome, thanks!

@xael-fry xael-fry added this to the 1.5.1 milestone Jul 11, 2018
@xael-fry xael-fry requested review from asolntsev and xael-fry July 11, 2018 06:58
Copy link
Contributor

@asolntsev asolntsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants