Add BigInteger binding #1269
Merged
Add BigInteger binding #1269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@wytrych Thank you for the PR, but could you also add a test case to |
Contributor
Author
|
@asolntsev test added. Let me know if it's ok and if so I will squash te commits. |
Contributor
asolntsev
approved these changes
Oct 12, 2018
There seems to be most basic types in the Binder but BigInteger was missing, even though BigDecimal was present. Without the BigInteger binding fixtures for models using this type will not load.
Contributor
Author
|
Branch squashed. |
Contributor
|
@wytrych thank you! Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be most basic types in the Binder but
BigInteger was missing, even though BigDecimal was present.
Without the BigInteger binding fixtures for models using this type
will not load.
Fixes #1268