Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@sbeigel
Copy link
Contributor

@sbeigel sbeigel commented Jan 17, 2019

Updated to Hibernate 5.4.0.Final with patch (unchanged) and some dependencies.

@sbeigel
Copy link
Contributor Author

sbeigel commented Jan 22, 2019

...5.4.1 just got released, so I immediately updated this PR :)

@tazmaniax
Copy link
Contributor

@sbeigel I'm thinking you meant 5.4.1 :) Nice one, thx!

@sbeigel
Copy link
Contributor Author

sbeigel commented Jan 22, 2019

lol, you're absolutely right! I'll edit the comment ;)

- org.hibernate -> hibernate-entitymanager 5.4.0.Final
- org.hibernate -> hibernate-ehcache 5.4.0.Final
- org.hibernate -> hibernate-c3p0 5.4.1.Final
- org.hibernate -> hibernate-entitymanager 5.4.1.Final
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, you're right, I removed it!

@xael-fry xael-fry merged commit 7ea47aa into playframework:master Jan 25, 2019
@xael-fry
Copy link
Member

Merge and pushed in master.
Thanks

@xael-fry xael-fry added this to the 1.5.3 milestone Jan 25, 2019
@EddyVerbruggen
Copy link
Contributor

@sbeigel Do you perhaps recall why framework/lib/ehcache-2.10.6.jar was added as part of this PR? Previous versions of Play1 didn't unclude the ehcache-xxx.jar at all, and it's causing build issues for us.

@sbeigel
Copy link
Contributor Author

sbeigel commented Sep 15, 2019

@EddyVerbruggen ehcache-core 2.6.11 was the previous dependency, it was updated with this PR

@EddyVerbruggen
Copy link
Contributor

EddyVerbruggen commented Sep 15, 2019

@sbeigel Yes, that one was upgraded indeed (thanks!), but also, this one sneaked in and wasn't included before (nor a lower version).

@EddyVerbruggen
Copy link
Contributor

I guess we'll remove that lib from our play/libs folder for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants