Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Upgrade netty #4792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marcospereira merged 1 commit into from
Jul 1, 2015
Merged

Upgrade netty #4792

marcospereira merged 1 commit into from
Jul 1, 2015

Conversation

@mkurz
Copy link
Member

@mkurz mkurz commented Jun 30, 2015

@marcospereira
Copy link
Member

marcospereira commented Jun 30, 2015

Nice! It will fix #4432.

marcospereira added a commit that referenced this pull request Jul 1, 2015
@marcospereira
Merge pull request #4792 from mkurz/upgradeNetty
7b3799d 
Upgrade netty
@marcospereira marcospereira merged commit 7b3799d into playframework:master Jul 1, 2015
@marcospereira
Copy link
Member

marcospereira commented Jul 5, 2015

Backport here: 53ec18e

@jroper
Copy link
Member

jroper commented Jul 6, 2015

Actually, #4432 is already fixed in Play 2.4 since we don't use Netty's cookie decoder, but our own copy of it, it's 2.3.9 that is impacted by #4432.

@OlegYch
Copy link
Contributor

OlegYch commented Jul 12, 2015

i tried to use 3.4.10.Final with 2.3.9 and got this:

java.lang.NoSuchMethodError: org.jboss.netty.handler.codec.http.HttpRequest.getHeader(Ljava/lang/String;)Ljava/lang/String;
        at play.core.server.websocket.WebSocketHandshake$.getWebSocketLocation(WebSocketHandshake.scala:33)
        at play.core.server.websocket.WebSocketHandshake$.shake(WebSocketHandshake.scala:36)

@OlegYch
Copy link
Contributor

OlegYch commented Jul 12, 2015

3.10.4 that is

@jroper jroper added this to the 2.4.3 milestone Sep 7, 2015
@mkurz mkurz deleted the upgradeNetty branch February 17, 2016 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.4.3

Development

Successfully merging this pull request may close these issues.

4 participants

@mkurz @marcospereira @jroper @OlegYch