Http pipelining support #945
Conversation
…ecking whether the connection is still open before deciding to continue with the iteratee.
…sage. Also added the typesafe snapshot repo into dependency resolution when we're building a snapshot release.
|
Missing a space? :) |
|
play2-master #997 FAILURE |
|
The build is complaining about not being able to resolve Akka actors: sbt.ResolveException: unresolved dependency: com.typesafe.akka#akka-actor;2.0.1: not found I'm blowing away my local ivy cache and re-testing. All tests previously passed ok. I shall report back. |
|
I can reproduce the issue locally having blown away the ivy cache. I will fix it. |
…understanding - and also to fix an issue where dependencies were not being resolved from a ivy2 layout (at least I think that was the issue).
|
I have now fixed up the dependency resolution issue. I have verified the fix by blowing away my local ivy cache and running the entire test suite. |
|
play2-master #999 SUCCESS |
|
Looks fine to me. |
There was a problem hiding this comment.
I notice that there's an import for Channels._ for this file. I prefer Channels.close() over just close(), but if there are other usages in the same file you might want to check that their style is consistent with yours. Or, if there aren't other usages, the import can be removed.
There was a problem hiding this comment.
Sorry, I see the import was removed. :)
|
Looks good to me! |
|
Thanks @jroper and @richdougherty! |
|
This issue depends on issue #995 so that we can get the warm and fuzzies about our changes before merging the PR. |
|
Now no longer waiting for #995 as we've hit a blocker. @jroper and @richdougherty have inspected the code and the customer that originally raised the issue has tested it and confirmed that all now appears well. |
|
play2-master-PRs #36 SUCCESS |
|
this looks awesome! Wonder if we could also enable SPDY support[1] along similar lines? (unfortunately google does not seem to be too keen on turning on pipelining for chrome by default[2] which is a bummer) [1] http://www.javacodegeeks.com/2012/05/netty-using-spdy-and-http-transparently.html |
|
Thanks @pk11! I think supporting SPDY makes sense and we should raise a ticket for it. Btw http pipelining support was motivated by a customer requiring it, so there's definitely usage. I believe the Android world embraces http pipelining as well. |
|
@huntc that's true. In fact the iOS app we are building will use this new HTTP pipelining feature as well (iOS is supporting pipelining as of iOS 5.0[1]) SPDY would be useful mostly with desktop Chrome/Firefox. Thanks again! [1]http://www.guypo.com/mobile/ios5-top10-performance-changes/ |
|
(I created a ticket for SPDY support #1005) |
|
Thanks Peter! Sent from my iPhone On 13/04/2013, at 10:12 AM, Peter Hausel [email protected] wrote:
|
Replaces #898. Uses a new library at the typesafe hub. This library [1] provides pipelining support to Netty in the form of a handler.
The changes here constitute the changes required to Play in support of the new library. Some re-factoring of Play's upstream handler has been done in the process.
Given that the new library exists as a snapshot (at least for now), I've also enhanced the build to consider snapshots during the building of Play in snapshot form. Snapshots will not be resolved though when distributing Play - this is what we want of course.
[1] https://github.com/typesafehub/netty-http-pipelining
@Gissues:{"order":50,"status":"done"}