Using Plotlyjs.react instead of newPlot when updating

andrefarzat · andrefarzat · commit 2fb1397964aa · 2019-01-08T13:12:35.000-02:00
diff --git a/src/app/plotly/plot/plot.component.ts b/src/app/plotly/plot/plot.component.ts
@@ -210,9 +210,12 @@ export class PlotComponent implements OnInit, OnChanges, OnDestroy, DoCheck {
             throw error;
         }
 
-        return this.createPlot().then(() => {
+        return this.plotly.update(this.plotlyInstance, this.data, this.layout, this.config).then(() => {
             const figure = this.createFigure();
             this.update.emit(figure);
+        }, err => {
+            console.error('Error while updating plot:', err);
+            this.error.emit(err);
         });
     }
 
diff --git a/src/app/plotly/plotly.service.ts b/src/app/plotly/plotly.service.ts
@@ -59,7 +59,7 @@ export class PlotlyService {
     }
 
     public update(div: Plotly.PlotlyHTMLElement, data: Plotly.Data[], layout?: Partial<Plotly.Layout>, config?: Partial<Plotly.Config>) {
-        return this.getPlotly().update(div, data, layout, config);
+        return this.getPlotly().react(div, data, layout, config);
     }
 
     public resize(div: Plotly.PlotlyHTMLElement): void {

Original file line number	Diff line number	Diff line change
`@@ -210,9 +210,12 @@ export class PlotComponent implements OnInit, OnChanges, OnDestroy, DoCheck {`
`210`	`210`	`throw error;`
`211`	`211`	`}`
`212`	`212`
`213`		`- return this.createPlot().then(() => {`
	`213`	`+ return this.plotly.update(this.plotlyInstance, this.data, this.layout, this.config).then(() => {`
`214`	`214`	`const figure = this.createFigure();`
`215`	`215`	`this.update.emit(figure);`
	`216`	`+ }, err => {`
	`217`	`+ console.error('Error while updating plot:', err);`
	`218`	`+ this.error.emit(err);`
`216`	`219`	`});`
`217`	`220`	`}`
`218`	`221`
Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ export class PlotlyService {`
`59`	`59`	`}`
`60`	`60`
`61`	`61`	`public update(div: Plotly.PlotlyHTMLElement, data: Plotly.Data[], layout?: Partial<Plotly.Layout>, config?: Partial<Plotly.Config>) {`
`62`		`- return this.getPlotly().update(div, data, layout, config);`
	`62`	`+ return this.getPlotly().react(div, data, layout, config);`
`63`	`63`	`}`
`64`	`64`
`65`	`65`	`public resize(div: Plotly.PlotlyHTMLElement): void {`