Merge pull request #33 from plotly/error-handling

alexander-daniel · alexander-daniel · commit 562132d9b123 · 2015-10-26T11:01:54.000-04:00
handle request errors for `getFigure`, `getImage` and `stream`
diff --git a/index.js b/index.js
@@ -135,6 +135,10 @@ Plotly.prototype.stream = function(token, callback) {
         }
     });
 
+    stream.on('error', function (err) {
+        callback(err);
+    });
+
     if (stream.setTimeout) stream.setTimeout(Math.pow(2, 32) * 1000);
 
     return stream;
@@ -175,6 +179,10 @@ Plotly.prototype.getFigure = function (fileOwner, fileId, callback) {
         });
     });
 
+    req.on('error', function (err) {
+        callback(err);
+    });
+
     req.end();
 };
 
@@ -219,6 +227,11 @@ Plotly.prototype.getImage = function (figure, opts, callback) {
     }
 
     var req = https.request(options, handleResponse);
+
+    req.on('error', function (err) {
+        callback(err);
+    });
+
     req.write(payload);
     req.end();
 };
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "plotly",
-  "version": "1.0.2",
+  "version": "1.0.3",
   "description": "Simple node.js wrapper for the plot.ly API",
   "main": "index.js",
   "devDependencies": {

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "plotly",`
`3`		`- "version": "1.0.2",`
	`3`	`+ "version": "1.0.3",`
`4`	`4`	`"description": "Simple node.js wrapper for the plot.ly API",`
`5`	`5`	`"main": "index.js",`
`6`	`6`	`"devDependencies": {`