Remove delay for action after double click

mdtusz · mdtusz · commit 113e802a0e46 · 2016-03-24T11:09:26.000-04:00
diff --git a/src/plots/cartesian/constants.js b/src/plots/cartesian/constants.js
@@ -28,7 +28,7 @@ module.exports = {
 
     // ms between first mousedown and 2nd mouseup to constitute dblclick...
     // we don't seem to have access to the system setting
-    DBLCLICKDELAY: 600,
+    DBLCLICKDELAY: 300,
 
     // pixels to move mouse before you stop clamping to starting point
     MINDRAG: 8,
diff --git a/src/plots/cartesian/graph_interact.js b/src/plots/cartesian/graph_interact.js
@@ -1576,7 +1576,6 @@ function dragBox(gd, plotinfo, x, y, w, h, ns, ew) {
     function zoomDone(dragged, numClicks) {
         if(Math.min(box.h, box.w) < MINDRAG * 2) {
             if(numClicks === 2) doubleClick();
-            else pauseForDrag(gd);
 
             return removeZoombox(gd);
         }
@@ -1629,7 +1628,6 @@ function dragBox(gd, plotinfo, x, y, w, h, ns, ew) {
                     }
                 });
         }
-        else pauseForDrag(gd);
     }
 
     // scroll zoom, on all draggers except corners
@@ -1932,21 +1930,6 @@ function getEndText(ax, end) {
     }
 }
 
-function pauseForDrag(gd) {
-    // prevent more redraws until we know if a doubleclick
-    // has occurred
-    gd._dragging = true;
-    var deferredReplot = gd._replotPending;
-    gd._replotPending = false;
-
-    setTimeout(function() {
-        gd._replotPending = deferredReplot;
-        finishDrag(gd);
-    },
-        constants.DBLCLICKDELAY
-    );
-}
-
 function finishDrag(gd) {
     gd._dragging = false;
     if(gd._replotPending) Plotly.plot(gd);

Original file line number	Diff line number	Diff line change
`@@ -1576,7 +1576,6 @@ function dragBox(gd, plotinfo, x, y, w, h, ns, ew) {`
`1576`	`1576`	`function zoomDone(dragged, numClicks) {`
`1577`	`1577`	`if(Math.min(box.h, box.w) < MINDRAG * 2) {`
`1578`	`1578`	`if(numClicks === 2) doubleClick();`
`1579`		`- else pauseForDrag(gd);`
`1580`	`1579`
`1581`	`1580`	`return removeZoombox(gd);`
`1582`	`1581`	`}`
`@@ -1629,7 +1628,6 @@ function dragBox(gd, plotinfo, x, y, w, h, ns, ew) {`
`1629`	`1628`	`}`
`1630`	`1629`	`});`
`1631`	`1630`	`}`
`1632`		`- else pauseForDrag(gd);`
`1633`	`1631`	`}`
`1634`	`1632`
`1635`	`1633`	`// scroll zoom, on all draggers except corners`
`@@ -1932,21 +1930,6 @@ function getEndText(ax, end) {`
`1932`	`1930`	`}`
`1933`	`1931`	`}`
`1934`	`1932`
`1935`		`-function pauseForDrag(gd) {`
`1936`		`- // prevent more redraws until we know if a doubleclick`
`1937`		`- // has occurred`
`1938`		`- gd._dragging = true;`
`1939`		`- var deferredReplot = gd._replotPending;`
`1940`		`- gd._replotPending = false;`
`1941`		`-`
`1942`		`- setTimeout(function() {`
`1943`		`- gd._replotPending = deferredReplot;`
`1944`		`- finishDrag(gd);`
`1945`		`- },`
`1946`		`- constants.DBLCLICKDELAY`
`1947`		`- );`
`1948`		`-}`
`1949`		`-`
`1950`	`1933`	`function finishDrag(gd) {`
`1951`	`1934`	`gd._dragging = false;`
`1952`	`1935`	`if(gd._replotPending) Plotly.plot(gd);`