adjustments

archmoj · archmoj · commit 2dbebf1e87d6 · 2024-03-06T14:23:02.000-05:00
diff --git a/draftlogs/6889_fix.md b/draftlogs/6889_fix.md
@@ -1,2 +1,2 @@
- - Fix standoff position [[#6889](https://github.com/plotly/plotly.js/pull/6889)],
+ - Fix standoff position [[#6889](https://github.com/plotly/plotly.js/pull/6889), [#6914](https://github.com/plotly/plotly.js/pull/6914)],
    with thanks to @ayjayt for the contribution!
diff --git a/src/plots/cartesian/axes.js b/src/plots/cartesian/axes.js
@@ -2898,7 +2898,7 @@ function calcLabelLevelBbox(ax, cls, mainLinePositionShift) {
         });
     } else {
         var dummyCalc = axes.makeLabelFns(ax, mainLinePositionShift);
-        top = bottom = dummyCalc.yFn({dx: 0, dy: 0, fontSize: 0}); // I don't know what dx, dy is
+        top = bottom = dummyCalc.yFn({dx: 0, dy: 0, fontSize: 0});
         left = right = dummyCalc.xFn({dx: 0, dy: 0, fontSize: 0});
     }
 

Original file line number	Diff line number	Diff line change
`@@ -1,2 +1,2 @@`
`1`		`- - Fix standoff position [[#6889](https://github.com/plotly/plotly.js/pull/6889)],`
	`1`	`+ - Fix standoff position [[#6889](https://github.com/plotly/plotly.js/pull/6889), [#6914](https://github.com/plotly/plotly.js/pull/6914)],`
`2`	`2`	`with thanks to @ayjayt for the contribution!`
Original file line number	Diff line number	Diff line change
`@@ -2898,7 +2898,7 @@ function calcLabelLevelBbox(ax, cls, mainLinePositionShift) {`
`2898`	`2898`	`});`
`2899`	`2899`	`} else {`
`2900`	`2900`	`var dummyCalc = axes.makeLabelFns(ax, mainLinePositionShift);`
`2901`		`- top = bottom = dummyCalc.yFn({dx: 0, dy: 0, fontSize: 0}); // I don't know what dx, dy is`
	`2901`	`+ top = bottom = dummyCalc.yFn({dx: 0, dy: 0, fontSize: 0});`
`2902`	`2902`	`left = right = dummyCalc.xFn({dx: 0, dy: 0, fontSize: 0});`
`2903`	`2903`	`}`
`2904`	`2904`