Handle when collections aren't objects or object+array

camdecoster · camdecoster · commit 8ceebdf0600a · 2025-10-15T15:44:47.000-06:00
diff --git a/src/plot_api/helpers.js b/src/plot_api/helpers.js
@@ -529,7 +529,7 @@ const collectionsAreEqual = (collection1, collection2) => {
         }
 
         return true;
-    } else {
+    } else if ([collection1, collection2].every((a) => Lib.isPlainObject(a))) {
         if (Object.keys(collection1).length !== Object.keys(collection2).length) return false;
 
         for (const k in collection1) {
@@ -544,5 +544,7 @@ const collectionsAreEqual = (collection1, collection2) => {
 
         return true;
     }
+
+    return false;
 };
 exports.collectionsAreEqual = collectionsAreEqual;

Original file line number	Diff line number	Diff line change
`@@ -529,7 +529,7 @@ const collectionsAreEqual = (collection1, collection2) => {`
`529`	`529`	`}`
`530`	`530`
`531`	`531`	`return true;`
`532`		`- } else {`
	`532`	`+ } else if ([collection1, collection2].every((a) => Lib.isPlainObject(a))) {`
`533`	`533`	`if (Object.keys(collection1).length !== Object.keys(collection2).length) return false;`
`534`	`534`
`535`	`535`	`for (const k in collection1) {`
`@@ -544,5 +544,7 @@ const collectionsAreEqual = (collection1, collection2) => {`
`544`	`544`
`545`	`545`	`return true;`
`546`	`546`	`}`
	`547`	`+`
	`548`	`+ return false;`
`547`	`549`	`};`
`548`	`550`	`exports.collectionsAreEqual = collectionsAreEqual;`