Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit b4f44b1

Browse files
authored
Merge pull request #5919 from plotly/nodejs-v14.17.5
Use node.js v14 in tests and publishing
2 parents d3b1345 + 9a64710 commit b4f44b1

File tree

3 files changed

+13
-12
lines changed

3 files changed

+13
-12
lines changed

.circleci/config.yml

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ version: 2.0
1010
jobs:
1111
install-and-cibuild:
1212
docker:
13-
- image: circleci/node:12.22.5
13+
- image: circleci/node:14.17.5
1414
working_directory: ~/plotly.js
1515
steps:
1616
- checkout
@@ -34,7 +34,7 @@ jobs:
3434
timezone-jasmine:
3535
docker:
3636
# need '-browsers' version to test in real (xvfb-wrapped) browsers
37-
- image: circleci/node:12.22.5-browsers
37+
- image: circleci/node:14.17.5-browsers
3838
working_directory: ~/plotly.js
3939
steps:
4040
- attach_workspace:
@@ -63,7 +63,7 @@ jobs:
6363
no-gl-jasmine:
6464
docker:
6565
# need '-browsers' version to test in real (xvfb-wrapped) browsers
66-
- image: circleci/node:12.22.5-browsers
66+
- image: circleci/node:14.17.5-browsers
6767
environment:
6868
# Alaska time (arbitrary timezone to test date logic)
6969
TZ: "America/Anchorage"
@@ -79,7 +79,7 @@ jobs:
7979
webgl-jasmine:
8080
docker:
8181
# need '-browsers' version to test in real (xvfb-wrapped) browsers
82-
- image: circleci/node:12.22.5-browsers
82+
- image: circleci/node:14.17.5-browsers
8383
environment:
8484
# Alaska time (arbitrary timezone to test date logic)
8585
TZ: "America/Anchorage"
@@ -95,7 +95,7 @@ jobs:
9595
flaky-no-gl-jasmine:
9696
docker:
9797
# need '-browsers' version to test in real (xvfb-wrapped) browsers
98-
- image: circleci/node:12.22.5-browsers
98+
- image: circleci/node:14.17.5-browsers
9999
environment:
100100
# Alaska time (arbitrary timezone to test date logic)
101101
TZ: "America/Anchorage"
@@ -110,7 +110,7 @@ jobs:
110110
bundle-jasmine:
111111
docker:
112112
# need '-browsers' version to test in real (xvfb-wrapped) browsers
113-
- image: circleci/node:12.22.5-browsers
113+
- image: circleci/node:14.17.5-browsers
114114
environment:
115115
# Alaska time (arbitrary timezone to test date logic)
116116
TZ: "America/Anchorage"
@@ -143,7 +143,7 @@ jobs:
143143

144144
test-baselines:
145145
docker:
146-
- image: circleci/node:12.22.5
146+
- image: circleci/node:14.17.5
147147
working_directory: ~/plotly.js
148148
steps:
149149
- attach_workspace:
@@ -178,7 +178,7 @@ jobs:
178178

179179
test-exports:
180180
docker:
181-
- image: circleci/node:12.22.5
181+
- image: circleci/node:14.17.5
182182
working_directory: ~/plotly.js
183183
steps:
184184
- attach_workspace:
@@ -192,7 +192,7 @@ jobs:
192192

193193
mock-validation:
194194
docker:
195-
- image: circleci/node:12.22.5
195+
- image: circleci/node:14.17.5
196196
working_directory: ~/plotly.js
197197
steps:
198198
- attach_workspace:
@@ -206,7 +206,7 @@ jobs:
206206

207207
source-syntax:
208208
docker:
209-
- image: circleci/node:12.22.5
209+
- image: circleci/node:14.17.5
210210
working_directory: ~/plotly.js
211211
steps:
212212
- attach_workspace:
@@ -217,7 +217,7 @@ jobs:
217217

218218
publish-dist:
219219
docker:
220-
- image: circleci/node:12.22.5
220+
- image: circleci/node:14.17.5
221221
working_directory: ~/plotly.js
222222
steps:
223223
- checkout

draftlogs/5919_change.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
- Use node.js v14 in tests and publishing [[#5919](https://github.com/plotly/plotly.js/pull/5919)]

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@
5656
"start": "node devtools/test_dashboard/server.js",
5757
"baseline": "node test/image/make_baseline.js",
5858
"noci-baseline": "npm run cibuild && ./tasks/noci_test.sh image && git checkout dist && echo 'Please do not commit unless the change was expected!'",
59-
"preversion": "check-node-version --node 12 --npm 6.14 && npm-link-check && npm ls --prod",
59+
"preversion": "check-node-version --node 14 --npm 6.14 && npm-link-check && npm ls --prod",
6060
"version": "npm run build && npm run no-bad-char && git add -A lib dist build src/version.js",
6161
"postversion": "node -e \"console.log('Version bumped and committed. If ok, run: git push && git push --tags')\"",
6262
"postpublish": "node tasks/sync_packages.js",

0 commit comments

Comments
 (0)