improve name of _bundle option

archmoj · archmoj · commit cd0c60307abe · 2024-02-28T11:00:50.000-05:00
diff --git a/tasks/bundle.mjs b/tasks/bundle.mjs
@@ -70,7 +70,7 @@ tasks.push(function(done) {
 // Bundle plotly.js with meta
 tasks.push(function(done) {
     _bundle(pathToPlotlyIndex, pathToPlotlyDistWithMeta, {
-        noCompress: true
+        noCompressAttributes: true
     }, function() {
         prependFile.sync(pathToPlotlyDistWithMeta, header, common.throwOnError);
 
diff --git a/tasks/cibundle.mjs b/tasks/cibundle.mjs
@@ -13,12 +13,12 @@ import _bundle from './util/bundle_wrapper.mjs';
 
 // Bundle plotly.js and plotly.min.js
 _bundle(constants.pathToPlotlyIndex, constants.pathToPlotlyBuild, {
-    noCompress: true,
+    noCompressAttributes: true,
     pathToMinBundle: constants.pathToPlotlyBuildMin
 }, function() {
     // Bundle the geo assets
     _bundle(constants.pathToPlotlyGeoAssetsSrc, constants.pathToPlotlyGeoAssetsDist, {
-        noCompress: true,
+        noCompressAttributes: true,
         standalone: 'PlotlyGeoAssets'
     });
 });
diff --git a/tasks/util/bundle_wrapper.mjs b/tasks/util/bundle_wrapper.mjs
@@ -14,7 +14,7 @@ import transform from '../../tasks/compress_attributes.js';
  *  - standalone {string}
  *  Additional option:
  *  - pathToMinBundle {string} path to destination minified bundle
- *  - noCompress {boolean} skip attribute meta compression?
+ *  - noCompressAttributes {boolean} skip attribute meta compression?
  * @param {function} cb callback
  *
  * Outputs one bundle (un-minified) file if opts.pathToMinBundle is omitted.
@@ -27,7 +27,7 @@ export default async function _bundle(pathToIndex, pathToBundle, opts, cb) {
 
     config.entryPoints = [pathToIndex];
     config.outfile = pathToBundle || pathToMinBundle;
-    if(!opts.noCompress) config.plugins.push(browserifyAdapter(transform));
+    if(!opts.noCompressAttributes) config.plugins.push(browserifyAdapter(transform));
     if(opts.noPlugins) consfig.noPlugins = [];
 
     var pathToMinBundle = opts.pathToMinBundle;
