cleanData should modify textposition in place

alexcjohnson · alexcjohnson · commit f01bab9cbdb1 · 2018-02-07T23:09:19.000-05:00
so as to not muck up plotly.react immutable logic
diff --git a/src/plot_api/helpers.js b/src/plot_api/helpers.js
@@ -283,7 +283,9 @@ exports.cleanData = function(data, existingData) {
 
         if(!Registry.traceIs(trace, 'pie') && !Registry.traceIs(trace, 'bar')) {
             if(Array.isArray(trace.textposition)) {
-                trace.textposition = trace.textposition.map(cleanTextPosition);
+                for(i = 0; i < trace.textposition.length; i++) {
+                    trace.textposition[i] = cleanTextPosition(trace.textposition[i]);
+                }
             }
             else if(trace.textposition) {
                 trace.textposition = cleanTextPosition(trace.textposition);
