Thanks to visit codestin.com
Credit goes to github.com

Skip to content

qgrid - plotly conflict #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
djchou opened this issue Dec 8, 2015 · 6 comments
Closed

qgrid - plotly conflict #90

djchou opened this issue Dec 8, 2015 · 6 comments
Labels
community community contribution

Comments

@djchou
Copy link

djchou commented Dec 8, 2015

I'm using plotly offline in a jupyter notebook. I'm coming across an error that i can't seem to debug.

Here is my code:

import qgrid
import Quandl
import plotly
from plotly.offline import download_plotlyjs, init_notebook_mode, iplot

aapl = Quandl.get('yahoo/aapl')
qgrid.nbinstall(overwrite=True)

works ok

qgrid.show_grid(aapl)

init_notebook_mode()

no longer works ok

qgrid.show_grid(aapl)

The error message is
"
Javascript error adding output!
TypeError: Cannot read property 's' of undefined
See your browser Javascript console for more details.
"

@etpinard etpinard added the community community contribution label Jan 12, 2016
@etpinard
Copy link
Contributor

Unfortunately, it looks like qgrid uses the RequireJS module syntax whereas plotly.js uses CommonJS. The two are incompatible out of the box (more info here).

Here are some solutions:

Thanks for reporting this issue. That said, no plotly.js team member will devote time to fixing this issue in the short term.

@djchou
Copy link
Author

djchou commented Jan 12, 2016

Thats too bad. The combination of qgrid and plotly offline is powerful

@aggFTW
Copy link

aggFTW commented Jan 12, 2016

This scenario would be fantastic @etpinard :(

@etpinard
Copy link
Contributor

@djchou @aggFTW It would be great to fix this issue, I'm not saying we shouldn't.

But, plotly.js only has 3 full-time devs at the moment, so we have to make decision based on the amount of users affected. I doubt that many people use plotly.js together with qgrid. Please, prove me wrong if you have data saying otherwise.

Sorry for the inconvenience.

@akansal1
Copy link

@etpinard Even custom widgets in Jupyter Notebook use Requirejs, as I received similar error using date widgets example provided in the ipywidgets examples with plotly in notebook...

@etpinard etpinard added the bug something broken label Jan 14, 2016
@etpinard etpinard removed the bug something broken label Feb 2, 2016
@etpinard
Copy link
Contributor

etpinard commented Feb 2, 2016

After the experiment in #232, we conclude that the best to solve this issue is within plotly.py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community community contribution
Projects
None yet
Development

No branches or pull requests

4 participants