From 5927343446ff7a0e068f1d67dcadff2b05c2064b Mon Sep 17 00:00:00 2001 From: vadzimZgerski Date: Mon, 25 Nov 2019 22:35:25 +0300 Subject: [PATCH 1/5] Fix bug wheel event for IE. --- src/plots/cartesian/dragbox.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/plots/cartesian/dragbox.js b/src/plots/cartesian/dragbox.js index a8f2ed79cf0..c30eb820e18 100644 --- a/src/plots/cartesian/dragbox.js +++ b/src/plots/cartesian/dragbox.js @@ -1202,6 +1202,7 @@ function attachWheelEventHandler(element, handler) { if(!supportsPassive) { if(element.onwheel !== undefined) element.onwheel = handler; else if(element.onmousewheel !== undefined) element.onmousewheel = handler; + else { element.addEventListener('wheel', handler, {passive: false}); } } else { var wheelEventName = element.onwheel !== undefined ? 'wheel' : 'mousewheel'; From 9f6afbefef59151ff26d7b07ee3c5b63b99b6243 Mon Sep 17 00:00:00 2001 From: Vadzim Zgerski Date: Tue, 26 Nov 2019 15:25:16 +0300 Subject: [PATCH 2/5] Fix bug wheel event for IE --- src/plots/cartesian/dragbox.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/plots/cartesian/dragbox.js b/src/plots/cartesian/dragbox.js index c30eb820e18..23a406fc8d8 100644 --- a/src/plots/cartesian/dragbox.js +++ b/src/plots/cartesian/dragbox.js @@ -1202,7 +1202,10 @@ function attachWheelEventHandler(element, handler) { if(!supportsPassive) { if(element.onwheel !== undefined) element.onwheel = handler; else if(element.onmousewheel !== undefined) element.onmousewheel = handler; - else { element.addEventListener('wheel', handler, {passive: false}); } + else if(element.isAddedWheelEvent) { + element.isAddedWheelEvent = true; + element.addEventListener('wheel', handler, {passive: false}); + } } else { var wheelEventName = element.onwheel !== undefined ? 'wheel' : 'mousewheel'; From 84dbebb34f8c0817a2c8035f3f129f049039e5d3 Mon Sep 17 00:00:00 2001 From: vadzimZgerski Date: Mon, 25 Nov 2019 22:35:25 +0300 Subject: [PATCH 3/5] Fix bug wheel event for IE. --- src/plots/cartesian/dragbox.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/plots/cartesian/dragbox.js b/src/plots/cartesian/dragbox.js index 5b7130785f9..f65d9dbb955 100644 --- a/src/plots/cartesian/dragbox.js +++ b/src/plots/cartesian/dragbox.js @@ -1230,6 +1230,7 @@ function attachWheelEventHandler(element, handler) { if(!supportsPassive) { if(element.onwheel !== undefined) element.onwheel = handler; else if(element.onmousewheel !== undefined) element.onmousewheel = handler; + else { element.addEventListener('wheel', handler, {passive: false}); } } else { var wheelEventName = element.onwheel !== undefined ? 'wheel' : 'mousewheel'; From dca3f973c78c5a8ce0ae6d591f8520267619a6f2 Mon Sep 17 00:00:00 2001 From: Vadzim Zgerski Date: Tue, 26 Nov 2019 15:25:16 +0300 Subject: [PATCH 4/5] Fix bug wheel event for IE --- src/plots/cartesian/dragbox.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/plots/cartesian/dragbox.js b/src/plots/cartesian/dragbox.js index f65d9dbb955..8c549b43975 100644 --- a/src/plots/cartesian/dragbox.js +++ b/src/plots/cartesian/dragbox.js @@ -1230,7 +1230,10 @@ function attachWheelEventHandler(element, handler) { if(!supportsPassive) { if(element.onwheel !== undefined) element.onwheel = handler; else if(element.onmousewheel !== undefined) element.onmousewheel = handler; - else { element.addEventListener('wheel', handler, {passive: false}); } + else if(element.isAddedWheelEvent) { + element.isAddedWheelEvent = true; + element.addEventListener('wheel', handler, {passive: false}); + } } else { var wheelEventName = element.onwheel !== undefined ? 'wheel' : 'mousewheel'; From 3127d52ef8c4819235322cea5f8f2277011754d6 Mon Sep 17 00:00:00 2001 From: Maksim Date: Sat, 23 May 2020 14:02:51 +0300 Subject: [PATCH 5/5] fix typo (add negation for isAddedWheelEvent statement) --- src/plots/cartesian/dragbox.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/plots/cartesian/dragbox.js b/src/plots/cartesian/dragbox.js index 8c549b43975..573362f0047 100644 --- a/src/plots/cartesian/dragbox.js +++ b/src/plots/cartesian/dragbox.js @@ -1230,7 +1230,7 @@ function attachWheelEventHandler(element, handler) { if(!supportsPassive) { if(element.onwheel !== undefined) element.onwheel = handler; else if(element.onmousewheel !== undefined) element.onmousewheel = handler; - else if(element.isAddedWheelEvent) { + else if(!element.isAddedWheelEvent) { element.isAddedWheelEvent = true; element.addEventListener('wheel', handler, {passive: false}); }