From 913c9e8e209bce525184fba4f24ae694fb32f44c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=89tienne=20T=C3=A9treault-Pinard?= Date: Thu, 26 May 2016 10:33:15 -0400 Subject: [PATCH] init Float32Array with explicit length of 0 --- src/traces/contourgl/convert.js | 4 ++-- src/traces/scattergl/convert.js | 24 ++++++++++++------------ 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/src/traces/contourgl/convert.js b/src/traces/contourgl/convert.js index 5abb76dbb55..aa9408672f0 100644 --- a/src/traces/contourgl/convert.js +++ b/src/traces/contourgl/convert.js @@ -32,7 +32,7 @@ function Contour(scene, uid) { this.bounds = [0, 0, 0, 0]; this.contourOptions = { - z: new Float32Array(), + z: new Float32Array(0), x: [], y: [], shape: [0, 0], @@ -44,7 +44,7 @@ function Contour(scene, uid) { this.contour._trace = this; this.heatmapOptions = { - z: new Float32Array(), + z: new Float32Array(0), x: [], y: [], shape: [0, 0], diff --git a/src/traces/scattergl/convert.js b/src/traces/scattergl/convert.js index 98f0b3da500..0cb7f0e121c 100644 --- a/src/traces/scattergl/convert.js +++ b/src/traces/scattergl/convert.js @@ -48,7 +48,7 @@ function LineWithMarkers(scene, uid) { this.hasLines = false; this.lineOptions = { - positions: new Float32Array(), + positions: new Float32Array(0), color: [0, 0, 0, 1], width: 1, fill: [false, false, false, false], @@ -64,8 +64,8 @@ function LineWithMarkers(scene, uid) { this.hasErrorX = false; this.errorXOptions = { - positions: new Float32Array(), - errors: new Float32Array(), + positions: new Float32Array(0), + errors: new Float32Array(0), lineWidth: 1, capSize: 0, color: [0, 0, 0, 1] @@ -75,8 +75,8 @@ function LineWithMarkers(scene, uid) { this.hasErrorY = false; this.errorYOptions = { - positions: new Float32Array(), - errors: new Float32Array(), + positions: new Float32Array(0), + errors: new Float32Array(0), lineWidth: 1, capSize: 0, color: [0, 0, 0, 1] @@ -86,7 +86,7 @@ function LineWithMarkers(scene, uid) { this.hasMarkers = false; this.scatterOptions = { - positions: new Float32Array(), + positions: new Float32Array(0), sizes: [], colors: [], glyphs: [], @@ -330,13 +330,13 @@ proto.updateFast = function(options) { this.scatter.update(this.scatterOptions); } else { - this.scatterOptions.positions = new Float32Array(); + this.scatterOptions.positions = new Float32Array(0); this.scatterOptions.glyphs = []; this.scatter.update(this.scatterOptions); } // turn off fancy scatter plot - this.scatterOptions.positions = new Float32Array(); + this.scatterOptions.positions = new Float32Array(0); this.scatterOptions.glyphs = []; this.fancyScatter.update(this.scatterOptions); @@ -455,13 +455,13 @@ proto.updateFancy = function(options) { this.fancyScatter.update(this.scatterOptions); } else { - this.scatterOptions.positions = new Float32Array(); + this.scatterOptions.positions = new Float32Array(0); this.scatterOptions.glyphs = []; this.fancyScatter.update(this.scatterOptions); } // turn off fast scatter plot - this.scatterOptions.positions = new Float32Array(); + this.scatterOptions.positions = new Float32Array(0); this.scatterOptions.glyphs = []; this.scatter.update(this.scatterOptions); @@ -514,7 +514,7 @@ proto.updateLines = function(options, positions) { this.lineOptions.fillColor = [fillColor, fillColor, fillColor, fillColor]; } else { - this.lineOptions.positions = new Float32Array(); + this.lineOptions.positions = new Float32Array(0); } this.line.update(this.lineOptions); @@ -537,7 +537,7 @@ proto.updateError = function(axLetter, options, positions, errors) { errorObjOptions.color = convertColor(errorOptions.color, 1, 1); } else { - errorObjOptions.positions = new Float32Array(); + errorObjOptions.positions = new Float32Array(0); } errorObj.update(errorObjOptions);