diff --git a/draftlogs/6893_fix.md b/draftlogs/6893_fix.md new file mode 100644 index 00000000000..13bd218710d --- /dev/null +++ b/draftlogs/6893_fix.md @@ -0,0 +1 @@ +- Fix possible NPE when `textinfo: "none"` for pie and funnelarea traces diff --git a/src/traces/funnelarea/defaults.js b/src/traces/funnelarea/defaults.js index 6ce2a86bab9..9067c6f2542 100644 --- a/src/traces/funnelarea/defaults.js +++ b/src/traces/funnelarea/defaults.js @@ -55,6 +55,8 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout moduleHasTextangle: false, moduleHasInsideanchor: false }); + } else if(textInfo === 'none') { + coerce('textposition', 'none'); } handleDomainDefaults(traceOut, layout, coerce); diff --git a/src/traces/pie/defaults.js b/src/traces/pie/defaults.js index ec66b67e08f..f2aef62d0e2 100644 --- a/src/traces/pie/defaults.js +++ b/src/traces/pie/defaults.js @@ -111,6 +111,8 @@ function supplyDefaults(traceIn, traceOut, defaultColor, layout) { if(textposition === 'inside' || textposition === 'auto' || Array.isArray(textposition)) { coerce('insidetextorientation'); } + } else if(textInfo === 'none') { + coerce('textposition', 'none'); } handleDomainDefaults(traceOut, layout, coerce);