Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit cd26c8f

Browse files
marthacryanmarthacryan
committed
Use github actions instead of circleci for checking js build files
1 parent f918835 commit cd26c8f

File tree

7 files changed

+77
-68
lines changed

7 files changed

+77
-68
lines changed

‎.circleci/config.yml

Lines changed: 0 additions & 63 deletions
Original file line numberDiff line numberDiff line change
@@ -163,65 +163,6 @@ jobs:
163163
pandas_version: <<parameters.pandas_version>>
164164
numpy_version: <<parameters.numpy_version>>
165165

166-
check-js-build:
167-
docker:
168-
- image: cimg/python:3.12-node
169-
environment:
170-
LANG: en_US.UTF-8
171-
resource_class: large
172-
173-
steps:
174-
- checkout
175-
- run:
176-
name: Skip if no JS changes
177-
command: |
178-
git diff --name-only origin/main...HEAD | grep '^js/' || exit 0
179-
- run:
180-
name: Copy current files to a temporary directory
181-
command: |
182-
cp -R plotly/labextension/ plotly/labextension-tmp/
183-
- run:
184-
name: Install dependencies
185-
command: |
186-
curl -LsSf https://astral.sh/uv/install.sh | sh
187-
uv venv
188-
source .venv/bin/activate
189-
uv pip install jupyter
190-
cd js
191-
npm ci
192-
npm run build
193-
- run:
194-
name: Check JupyterLab build artifacts
195-
command: |
196-
# 1. Compare all files except 'Only in' cases
197-
diff -qr plotly/labextension-tmp/static plotly/labextension/static | grep -v '^Only in' > build_diff.txt || true
198-
cat build_diff.txt
199-
200-
# Remove the "load" line from both package.json files before comparing
201-
grep -v '"load": "static/' plotly/labextension/package.json > pkg1.json
202-
grep -v '"load": "static/' plotly/labextension-tmp/package.json > pkg2.json
203-
204-
# Compare stripped versions
205-
diff pkg1.json pkg2.json > package_json_diff.txt || true
206-
207-
# 5. Final check
208-
if [ -s build_diff.txt ] || [ -s package_json_diff.txt ]; then
209-
echo "❌ Build artifacts differ:"
210-
echo "--- Unexpected diffs ---"
211-
cat build_diff.txt
212-
echo "--- Unexpected package.json diffs ---"
213-
cat package_json_diff.txt
214-
echo "Please replace the `plotly/labextension` directory with the artifacts of this CI run."
215-
exit 1
216-
else
217-
echo "✅ Build artifacts match expected output (ignoring known 'load' hash in package.json)."
218-
fi
219-
- store_artifacts:
220-
path: plotly/labextension
221-
destination: labextension
222-
when: on_fail
223-
224-
225166
# Percy
226167
python_311_percy:
227168
docker:
@@ -462,10 +403,6 @@ workflows:
462403
jobs:
463404
- full_build
464405

465-
check_js_build:
466-
jobs:
467-
- check-js-build
468-
469406
build:
470407
jobs:
471408
- test_core_py:

‎.github/workflows/check-js-build.yml

Lines changed: 72 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,72 @@
1+
on:
2+
push:
3+
paths:
4+
- 'js/**'
5+
- 'plotly/labextension/**'
6+
7+
jobs:
8+
check-js-build:
9+
name: Check JS build artifacts
10+
runs-on: ubuntu-latest
11+
steps:
12+
- uses: actions/checkout@v4
13+
with:
14+
persist-credentials: false
15+
- name: Set up Python
16+
uses: actions/setup-python@v5
17+
with:
18+
python-version: "3.x"
19+
20+
- name: Install Node
21+
uses: actions/setup-node@v2
22+
with:
23+
node-version: '18'
24+
25+
- name: Copy current files to a temporary directory
26+
run: |
27+
cp -R plotly/labextension/ plotly/labextension-tmp/
28+
29+
- name: Install dependencies
30+
run: |
31+
curl -LsSf https://astral.sh/uv/install.sh | sh
32+
uv venv
33+
source .venv/bin/activate
34+
uv pip install jupyter
35+
cd js
36+
npm ci
37+
npm run build
38+
- name: Check JupyterLab build artifacts
39+
run: |
40+
# 1. Hash contents of all static files, sort by content hash
41+
find plotly/labextension/static -type f -exec sha256sum {} \; | awk '{print $1}' | sort > new_hashes.txt
42+
find plotly/labextension-tmp/static -type f -exec sha256sum {} \; | awk '{print $1}' | sort > old_hashes.txt
43+
44+
# 2. Compare the sorted content hashes
45+
diff old_hashes.txt new_hashes.txt > content_diff.txt || true
46+
cat content_diff.txt
47+
48+
# Remove the "load" line from both package.json files before comparing
49+
grep -v '"load": "static/' plotly/labextension/package.json > pkg1.json
50+
grep -v '"load": "static/' plotly/labextension-tmp/package.json > pkg2.json
51+
52+
# Compare stripped versions
53+
diff pkg1.json pkg2.json > package_json_diff.txt || true
54+
55+
# 5. Final check
56+
if [ -s content_diff.txt ] || [ -s package_json_diff.txt ]; then
57+
echo "❌ Build artifacts differ:"
58+
echo "--- Unexpected diffs ---"
59+
cat content_diff.txt
60+
echo "--- Unexpected package.json diffs ---"
61+
cat package_json_diff.txt
62+
echo "Please replace the `plotly/labextension` directory with the artifacts of this CI run."
63+
exit 1
64+
else
65+
echo "✅ Build artifacts match expected output (ignoring known 'load' hash in package.json)."
66+
fi
67+
68+
- name: Store the build artifacts from plotly/labextension
69+
uses: actions/upload-artifact@v4
70+
with:
71+
name: labextension
72+
path: plotly/labextension

‎js/lib/mimeExtension.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎plotly/labextension/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
"mimeExtension": true,
3333
"outputDir": "../plotly/labextension",
3434
"_build": {
35-
"load": "static/remoteEntry.ad7567ddab772c2f7bb4.js",
35+
"load": "static/remoteEntry.b5df9c0e83570c3ef81a.js",
3636
"mimeExtension": "./mimeExtension"
3737
}
3838
}

‎plotly/labextension/static/340.183c15a978a3bd06e343.js renamed to ‎plotly/labextension/static/340.02f12bf213755b248b6b.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎plotly/labextension/static/340.183c15a978a3bd06e343.js.LICENSE.txt renamed to ‎plotly/labextension/static/340.02f12bf213755b248b6b.js.LICENSE.txt

File renamed without changes.

‎plotly/labextension/static/remoteEntry.ad7567ddab772c2f7bb4.js renamed to ‎plotly/labextension/static/remoteEntry.b5df9c0e83570c3ef81a.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)