virtio_net: enable VQs early

mstsirkin · rustyrussell · commit 4baf1e33d084 · 2014-10-15T10:25:02.000+10:30
virtio spec requires drivers to set DRIVER_OK before using VQs.
This is set automatically after probe returns, virtio net violated this
rule by using receive VQs within probe.

To fix, call virtio_device_ready before using VQs.

Signed-off-by: Michael S. Tsirkin &lt;mst@redhat.com&gt;
Reviewed-by: Cornelia Huck &lt;cornelia.huck@de.ibm.com&gt;
Signed-off-by: Rusty Russell &lt;rusty@rustcorp.com.au&gt;
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
@@ -1792,6 +1792,8 @@ static int virtnet_probe(struct virtio_device *vdev)
 		goto free_vqs;
 	}
 
+	virtio_device_ready(vdev);
+
 	/* Last of all, set up some receive buffers. */
 	for (i = 0; i < vi->curr_queue_pairs; i++) {
 		try_fill_recv(&vi->rq[i], GFP_KERNEL);

Original file line number	Diff line number	Diff line change
`@@ -1792,6 +1792,8 @@ static int virtnet_probe(struct virtio_device *vdev)`
`1792`	`1792`	`goto free_vqs;`
`1793`	`1793`	`}`
`1794`	`1794`
	`1795`	`+ virtio_device_ready(vdev);`
	`1796`	`+`
`1795`	`1797`	`/* Last of all, set up some receive buffers. */`
`1796`	`1798`	`for (i = 0; i < vi->curr_queue_pairs; i++) {`
`1797`	`1799`	`try_fill_recv(&vi->rq[i], GFP_KERNEL);`