NFS: Ensure the server has an up to date ctime before renaming

Trond Myklebust · amschuma-ntap · commit 6ff9d99bb88f · 2022-01-06T14:00:20.000-05:00
Renaming a file is required by POSIX to update the file ctime, so ensure that the file data is synced to disk so that we don't clobber the updated ctime by writing back after creating the hard link. Fixes: f2c2c55 ("NFS: Move delegation recall into the NFSv4 callback for rename_setup()") Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com> Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c
@@ -2470,6 +2470,8 @@ int nfs_rename(struct user_namespace *mnt_userns, struct inode *old_dir,
 		}
 	}
 
+	if (S_ISREG(old_inode->i_mode))
+		nfs_sync_inode(old_inode);
 	task = nfs_async_rename(old_dir, new_dir, old_dentry, new_dentry, NULL);
 	if (IS_ERR(task)) {
 		error = PTR_ERR(task);

Original file line number	Diff line number	Diff line change
`@@ -2470,6 +2470,8 @@ int nfs_rename(struct user_namespace mnt_userns, struct inode old_dir,`
`2470`	`2470`	`}`
`2471`	`2471`	`}`
`2472`	`2472`
	`2473`	`+ if (S_ISREG(old_inode->i_mode))`
	`2474`	`+ nfs_sync_inode(old_inode);`
`2473`	`2475`	`task = nfs_async_rename(old_dir, new_dir, old_dentry, new_dentry, NULL);`
`2474`	`2476`	`if (IS_ERR(task)) {`
`2475`	`2477`	`error = PTR_ERR(task);`