netfilter: nf_tables: use kfree_rcu(ptr, rcu) to release hooks in clean_net path

ummakynes · ummakynes · commit ab5e5c062f67 · 2022-06-01T16:01:54.000+02:00
Use kfree_rcu(ptr, rcu) variant instead as described by ae08983 ("netfilter: nf_tables: prefer kfree_rcu(ptr, rcu) variant"). Fixes: f9a4300 ("netfilter: nf_tables: double hook unregistration in netns path") Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c
@@ -7332,7 +7332,7 @@ static void __nft_unregister_flowtable_net_hooks(struct net *net,
 		nf_unregister_net_hook(net, &hook->ops);
 		if (release_netdev) {
 			list_del(&hook->list);
-			kfree_rcu(hook);
+			kfree_rcu(hook, rcu);
 		}
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -7332,7 +7332,7 @@ static void __nft_unregister_flowtable_net_hooks(struct net *net,`
`7332`	`7332`	`nf_unregister_net_hook(net, &hook->ops);`
`7333`	`7333`	`if (release_netdev) {`
`7334`	`7334`	`list_del(&hook->list);`
`7335`		`- kfree_rcu(hook);`
	`7335`	`+ kfree_rcu(hook, rcu);`
`7336`	`7336`	`}`
`7337`	`7337`	`}`
`7338`	`7338`	`}`