tty: Fix a possible resource leak in icom_probe

Huang Guobin · gregkh · commit ee157a79e7c8 · 2022-04-15T08:42:40.000+02:00
When pci_read_config_dword failed, call pci_release_regions() and pci_disable_device() to recycle the resource previously allocated. Reviewed-by: Jiri Slaby <jirislaby@kernel.org> Signed-off-by: Huang Guobin <huangguobin4@huawei.com> Link: https://lore.kernel.org/r/20220331091005.3290753-1-huangguobin4@huawei.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
diff --git a/drivers/tty/serial/icom.c b/drivers/tty/serial/icom.c
@@ -1501,7 +1501,7 @@ static int icom_probe(struct pci_dev *dev,
 	retval = pci_read_config_dword(dev, PCI_COMMAND, &command_reg);
 	if (retval) {
 		dev_err(&dev->dev, "PCI Config read FAILED\n");
-		return retval;
+		goto probe_exit0;
 	}
 
 	pci_write_config_dword(dev, PCI_COMMAND,

Original file line number	Diff line number	Diff line change
`@@ -1501,7 +1501,7 @@ static int icom_probe(struct pci_dev *dev,`
`1501`	`1501`	`retval = pci_read_config_dword(dev, PCI_COMMAND, &command_reg);`
`1502`	`1502`	`if (retval) {`
`1503`	`1503`	`dev_err(&dev->dev, "PCI Config read FAILED\n");`
`1504`		`- return retval;`
	`1504`	`+ goto probe_exit0;`
`1505`	`1505`	`}`
`1506`	`1506`
`1507`	`1507`	`pci_write_config_dword(dev, PCI_COMMAND,`