Fix test for table existance to allow mixed-case and whitespace in

Thomas G. Lockhart · Thomas G. Lockhart · commit 2795fae5bf9a · 1998-11-12T15:39:06.000Z
the table name. Problem reported by Billy Allie.
diff --git a/src/backend/catalog/heap.c b/src/backend/catalog/heap.c
@@ -7,7 +7,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/catalog/heap.c,v 1.64 1998/09/01 04:27:29 momjian Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/catalog/heap.c,v 1.65 1998/11/12 15:39:06 thomas Exp $
  *
  * INTERFACE ROUTINES
  *		heap_create()			- Create an uncataloged heap relation
@@ -1515,7 +1515,10 @@ StoreRelCheck(Relation rel, ConstrCheck *check)
 	char		nulls[4] = {' ', ' ', ' ', ' '};
 	extern GlobalMemory CacheCxt;
 
-	sprintf(str, "select 1 from %.*s where %s",
+	/* Check for table's existance. Surround table name with double-quotes
+	 * to allow mixed-case and whitespace names. - thomas 1998-11-12
+	 */
+	sprintf(str, "select 1 from \"%.*s\" where %s",
 			NAMEDATALEN, rel->rd_rel->relname.data, check->ccsrc);
 	setheapoverride(true);
 	planTree_list = (List *) pg_parse_and_plan(str, NULL, 0, &queryTree_list, None, FALSE);

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`*`
`8`	`8`	`*`
`9`	`9`	`* IDENTIFICATION`
`10`		`- * $Header: /cvsroot/pgsql/src/backend/catalog/heap.c,v 1.64 1998/09/01 04:27:29 momjian Exp $`
	`10`	`+ * $Header: /cvsroot/pgsql/src/backend/catalog/heap.c,v 1.65 1998/11/12 15:39:06 thomas Exp $`
`11`	`11`	`*`
`12`	`12`	`* INTERFACE ROUTINES`
`13`	`13`	`* heap_create() - Create an uncataloged heap relation`
`@@ -1515,7 +1515,10 @@ StoreRelCheck(Relation rel, ConstrCheck *check)`
`1515`	`1515`	`char nulls[4] = {' ', ' ', ' ', ' '};`
`1516`	`1516`	`extern GlobalMemory CacheCxt;`
`1517`	`1517`
`1518`		`- sprintf(str, "select 1 from %.*s where %s",`
	`1518`	`+ /* Check for table's existance. Surround table name with double-quotes`
	`1519`	`+ * to allow mixed-case and whitespace names. - thomas 1998-11-12`
	`1520`	`+ */`
	`1521`	`+ sprintf(str, "select 1 from \"%.*s\" where %s",`
`1519`	`1522`	`NAMEDATALEN, rel->rd_rel->relname.data, check->ccsrc);`
`1520`	`1523`	`setheapoverride(true);`
`1521`	`1524`	`planTree_list = (List *) pg_parse_and_plan(str, NULL, 0, &queryTree_list, None, FALSE);`