Add CHECK_FOR_INTERRUPTS while decoding changes.

Amit Kapila · Amit Kapila · commit 6b50433e865e · 2022-08-23T08:39:31.000+05:30
While decoding changes in a loop, if we skip all the changes there is no CFI making the loop uninterruptible. Reported-by: Whale Song and Andrey Borodin Bug: 17580 Author: Masahiko Sawada Reviwed-by: Amit Kapila Backpatch-through: 10 Discussion: https://postgr.es/m/17580-849c1d5b6d7eb422@postgresql.org Discussion: https://postgr.es/m/B319ECD6-9A28-4CDF-A8F4-3591E0BF2369@yandex-team.ru
diff --git a/src/backend/replication/logical/reorderbuffer.c b/src/backend/replication/logical/reorderbuffer.c
@@ -1525,6 +1525,8 @@ ReorderBufferCommit(ReorderBuffer *rb, TransactionId xid,
 			Relation	relation = NULL;
 			Oid			reloid;
 
+			CHECK_FOR_INTERRUPTS();
+
 			switch (change->action)
 			{
 				case REORDER_BUFFER_CHANGE_INTERNAL_SPEC_CONFIRM:

Original file line number	Diff line number	Diff line change
`@@ -1525,6 +1525,8 @@ ReorderBufferCommit(ReorderBuffer *rb, TransactionId xid,`
`1525`	`1525`	`Relation relation = NULL;`
`1526`	`1526`	`Oid reloid;`
`1527`	`1527`
	`1528`	`+ CHECK_FOR_INTERRUPTS();`
	`1529`	`+`
`1528`	`1530`	`switch (change->action)`
`1529`	`1531`	`{`
`1530`	`1532`	`case REORDER_BUFFER_CHANGE_INTERNAL_SPEC_CONFIRM:`