Now that the shared library name can be adjusted in the library test,

bmomjian · bmomjian · commit 6d5aae7afacc · 2012-01-25T09:35:17.000-05:00
have pg_upgrade allocate a maximum fixed size buffer for testing the
library file name, rather than base the allocation on the library name.

Backpatch to 9.1.
diff --git a/contrib/pg_upgrade/function.c b/contrib/pg_upgrade/function.c
@@ -225,7 +225,7 @@ check_loadable_libraries(void)
 	{
 		char	   *lib = os_info.libraries[libnum];
 		int			llen = strlen(lib);
-		char	   *cmd = (char *) pg_malloc(8 + 2 * llen + 1);
+		char		cmd[7 + 2 * MAXPGPATH + 1];
 		PGresult   *res;
 
 		/*
@@ -266,7 +266,6 @@ check_loadable_libraries(void)
 		}
 
 		PQclear(res);
-		pg_free(cmd);
 	}
 
 	PQfinish(conn);

Original file line number	Diff line number	Diff line change
`@@ -225,7 +225,7 @@ check_loadable_libraries(void)`
`225`	`225`	`{`
`226`	`226`	`char *lib = os_info.libraries[libnum];`
`227`	`227`	`int llen = strlen(lib);`
`228`		`- char cmd = (char ) pg_malloc(8 + 2 * llen + 1);`
	`228`	`+ char cmd[7 + 2 * MAXPGPATH + 1];`
`229`	`229`	`PGresult *res;`
`230`	`230`
`231`	`231`	`/*`
`@@ -266,7 +266,6 @@ check_loadable_libraries(void)`
`266`	`266`	`}`
`267`	`267`
`268`	`268`	`PQclear(res);`
`269`		`- pg_free(cmd);`
`270`	`269`	`}`
`271`	`270`
`272`	`271`	`PQfinish(conn);`