Fix typo in initdb's SCRAM password processing.

tglsfdc · tglsfdc · commit 835cc1136745 · 2017-03-12T15:57:03.000-04:00
Noted by Coverity (a rather impressive catch).

Michael Paquier
diff --git a/src/bin/initdb/initdb.c b/src/bin/initdb/initdb.c
@@ -2331,7 +2331,7 @@ check_need_password(const char *authmethodlocal, const char *authmethodhost)
 		 strcmp(authmethodlocal, "scram") == 0) &&
 		(strcmp(authmethodhost, "md5") == 0 ||
 		 strcmp(authmethodhost, "password") == 0 ||
-		 strcmp(authmethodlocal, "scram") == 0) &&
+		 strcmp(authmethodhost, "scram") == 0) &&
 		!(pwprompt || pwfilename))
 	{
 		fprintf(stderr, _("%s: must specify a password for the superuser to enable %s authentication\n"), progname,

Original file line number	Diff line number	Diff line change
`@@ -2331,7 +2331,7 @@ check_need_password(const char authmethodlocal, const char authmethodhost)`
`2331`	`2331`	`strcmp(authmethodlocal, "scram") == 0) &&`
`2332`	`2332`	`(strcmp(authmethodhost, "md5") == 0 \|\|`
`2333`	`2333`	`strcmp(authmethodhost, "password") == 0 \|\|`
`2334`		`- strcmp(authmethodlocal, "scram") == 0) &&`
	`2334`	`+ strcmp(authmethodhost, "scram") == 0) &&`
`2335`	`2335`	`!(pwprompt \|\| pwfilename))`
`2336`	`2336`	`{`
`2337`	`2337`	`fprintf(stderr, _("%s: must specify a password for the superuser to enable %s authentication\n"), progname,`