pg_dump: Have _EndLO report errno after CFH->write_func() failure

alvherre · alvherre · commit 98bd4c72fd6c · 2023-05-17T18:55:51.000+02:00
Other callers of that function do things this way, but this one didn't
get the memo.
diff --git a/src/bin/pg_dump/pg_backup_directory.c b/src/bin/pg_dump/pg_backup_directory.c
@@ -697,7 +697,13 @@ _EndLO(ArchiveHandle *AH, TocEntry *te, Oid oid)
 	/* register the LO in blobs.toc */
 	len = snprintf(buf, sizeof(buf), "%u blob_%u.dat\n", oid, oid);
 	if (!CFH->write_func(buf, len, CFH))
-		pg_fatal("could not write to LOs TOC file");
+	{
+		/* if write didn't set errno, assume problem is no disk space */
+		if (errno == 0)
+			errno = ENOSPC;
+		pg_fatal("could not write to LOs TOC file: %s",
+				 CFH->get_error_func(CFH));
+	}
 }
 
 /*
