Fix some comments related to IO workers

michaelpq · michaelpq · commit c4c236ab5c41 · 2025-05-07T14:55:57.000+09:00
IO workers are treated as auxiliary processes. The comments fixed in this commit stated that there could be only one auxiliary process of each BackendType at the same time. This is not true for IO workers, as up to MAX_IO_WORKERS of them can co-exist at the same time. Author: Cédric Villemain <Cedric.Villemain@data-bene.io> Co-authored-by: Michael Paquier <michael@paquier.xyz> Discussion: https://postgr.es/m/e4a3ac45-abce-4b58-a043-b4a31cd11113@Data-Bene.io
diff --git a/src/backend/storage/ipc/procsignal.c b/src/backend/storage/ipc/procsignal.c
@@ -89,7 +89,8 @@ struct ProcSignalHeader
 /*
  * We reserve a slot for each possible ProcNumber, plus one for each
  * possible auxiliary process type.  (This scheme assumes there is not
- * more than one of any auxiliary process type at a time.)
+ * more than one of any auxiliary process type at a time, except for
+ * IO workers.)
  */
 #define NumProcSignalSlots	(MaxBackends + NUM_AUXILIARY_PROCS)
 
diff --git a/src/backend/storage/ipc/sinvaladt.c b/src/backend/storage/ipc/sinvaladt.c
@@ -198,7 +198,8 @@ typedef struct SISeg
 /*
  * We reserve a slot for each possible ProcNumber, plus one for each
  * possible auxiliary process type.  (This scheme assumes there is not
- * more than one of any auxiliary process type at a time.)
+ * more than one of any auxiliary process type at a time, except for
+ * IO workers.)
  */
 #define NumProcStateSlots	(MaxBackends + NUM_AUXILIARY_PROCS)
 
diff --git a/src/include/miscadmin.h b/src/include/miscadmin.h
@@ -353,7 +353,7 @@ typedef enum BackendType
 	 * Auxiliary processes. These have PGPROC entries, but they are not
 	 * attached to any particular database, and cannot run transactions or
 	 * even take heavyweight locks. There can be only one of each of these
-	 * running at a time.
+	 * running at a time, except for IO workers.
 	 *
 	 * If you modify these, make sure to update NUM_AUXILIARY_PROCS and the
 	 * glossary in the docs.

Original file line number	Diff line number	Diff line change
`@@ -353,7 +353,7 @@ typedef enum BackendType`
`353`	`353`	`* Auxiliary processes. These have PGPROC entries, but they are not`
`354`	`354`	`* attached to any particular database, and cannot run transactions or`
`355`	`355`	`* even take heavyweight locks. There can be only one of each of these`
`356`		`- * running at a time.`
	`356`	`+ * running at a time, except for IO workers.`
`357`	`357`	`*`
`358`	`358`	`* If you modify these, make sure to update NUM_AUXILIARY_PROCS and the`
`359`	`359`	`* glossary in the docs.`