Fix minor thinko in ProcGlobalShmemSize().

robertmhaas · robertmhaas · commit c573486ce975 · 2011-06-17T09:12:19.000-04:00
There's no need to add space for startupBufferPinWaitBufId, because
it's part of the PROC_HDR object for which this function already
allocates space.

This has been wrong for a while, but the only consequence is that our
shared memory allocation is increased by 4 bytes, so no back-patch.
diff --git a/src/backend/storage/lmgr/proc.c b/src/backend/storage/lmgr/proc.c
@@ -111,8 +111,6 @@ ProcGlobalShmemSize(void)
 	size = add_size(size, mul_size(MaxBackends, sizeof(PGPROC)));
 	/* ProcStructLock */
 	size = add_size(size, sizeof(slock_t));
-	/* startupBufferPinWaitBufId */
-	size = add_size(size, sizeof(NBuffers));
 
 	return size;
 }

Original file line number	Diff line number	Diff line change
`@@ -111,8 +111,6 @@ ProcGlobalShmemSize(void)`
`111`	`111`	`size = add_size(size, mul_size(MaxBackends, sizeof(PGPROC)));`
`112`	`112`	`/* ProcStructLock */`
`113`	`113`	`size = add_size(size, sizeof(slock_t));`
`114`		`- /* startupBufferPinWaitBufId */`
`115`		`- size = add_size(size, sizeof(NBuffers));`
`116`	`114`
`117`	`115`	`return size;`
`118`	`116`	`}`