Revert support of FDW pushdowns because of unstability.

danolivo · danolivo · commit e72f1a6260a8 · 2021-06-25T07:02:42.000+03:00
Add ignore option in pg_regress schedule for non-passed tests.
diff --git a/parallel_schedule b/parallel_schedule
@@ -13,6 +13,7 @@
 # ----------
 # The first group of parallel tests
 # ----------
+
 test: boolean char name varchar text int2 int4 int8 oid float4 float8 bit numeric txid uuid enum money rangetypes pg_lsn regproc
 
 # ----------
@@ -61,15 +62,16 @@ test: create_aggregate create_function_3 create_cast constraints triggers select
 # sanity_check does a vacuum, affecting the sort order of SELECT *
 # results. So it should not run parallel to other tests.
 # ----------
-# test: sanity_check
+ignore: sanity_check
+test: sanity_check
 
 # ----------
 # Another group of parallel tests
 # Note: the ignore: line does not run random, just mark it as ignorable
 # ----------
 ignore: random
 test: select_into select_distinct select_distinct_on select_implicit select_having case aggregates transactions random portals arrays btree_index hash_index update delete namespace prepared_xacts
-# test: subselect union join
+test: subselect union join
 
 # ----------
 # Another group of parallel tests
@@ -86,7 +88,7 @@ test: create_table_like alter_generic alter_operator misc async dbsize misc_func
 test: rules psql psql_crosstab amutils stats_ext
 
 # run by itself so it can run parallel workers
-# test: select_parallel
+test: select_parallel
 test: write_parallel
 
 # no relation related tests can be put in this group
@@ -108,7 +110,7 @@ test: json jsonb json_encoding jsonpath jsonpath_encoding jsonb_jsonpath
 # so keep this parallel group to at most 19 tests
 # ----------
 test: plancache limit plpgsql copy2 temp domain rangefuncs prepare conversion truncate alter_table sequence polymorphism rowtypes returning largeobject xml
-# test: with
+test: with
 
 # ----------
 # Another group of parallel tests
diff --git a/postprocessing.c b/postprocessing.c
@@ -603,47 +603,6 @@ aqo_copy_generic_path_info(PlannerInfo *root, Plan *dest, Path *src)
 		dest->path_clauses = ((JoinPath *) src)->joinrestrictinfo;
 		dest->path_jointype = ((JoinPath *) src)->jointype;
 	}
-	else if (src->type == T_ForeignPath)
-	{
-		ForeignPath *fpath = (ForeignPath *) src;
-		PgFdwRelationInfo *fpinfo = (PgFdwRelationInfo *) fpath->path.parent->fdw_private;
-
-		/*
-		 * Pushed down foreign join keeps clauses in special fdw_private
-		 * structure.
-		 * I'm not sure what fpinfo structure keeps clauses for sufficient time.
-		 * So, copy clauses.
-		 */
-
-		dest->path_clauses = list_concat(list_copy(fpinfo->joinclauses),
-										 list_copy(fpinfo->remote_conds));
-		dest->path_clauses = list_concat(dest->path_clauses,
-										 list_copy(fpinfo->local_conds));
-
-		dest->path_jointype = ((JoinPath *) src)->jointype;
-
-		dest->path_relids = get_list_of_relids(root, fpinfo->lower_subquery_rels);
-
-		if (fpinfo->outerrel)
-		{
-			dest->path_clauses = list_concat(dest->path_clauses,
-								list_copy(fpinfo->outerrel->baserestrictinfo));
-			dest->path_clauses = list_concat(dest->path_clauses,
-								list_copy(fpinfo->outerrel->joininfo));
-			dest->path_relids = list_concat(dest->path_relids,
-							get_list_of_relids(root, fpinfo->outerrel->relids));
-		}
-
-		if (fpinfo->innerrel)
-		{
-			dest->path_clauses = list_concat(dest->path_clauses,
-								list_copy(fpinfo->innerrel->baserestrictinfo));
-			dest->path_clauses = list_concat(dest->path_clauses,
-								list_copy(fpinfo->innerrel->joininfo));
-			dest->path_relids = list_concat(dest->path_relids,
-							get_list_of_relids(root, fpinfo->innerrel->relids));
-		}
-	}
 	else
 	{
 		dest->path_clauses = list_concat(
