Get rid of StampVariated base class. It makes code more comples, instead of making it more simple

nataraj-hates-MS-for-stealing-github · nataraj-hates-MS-for-stealing-github · commit c9a00e2aa609 · 2023-01-19T13:38:26.000+03:00
diff --git a/blobstamper/stamp.h b/blobstamper/stamp.h
@@ -107,16 +107,6 @@ StampBaseV<T>::ExtractBin(Blob &blob)
   return v;
 }
 
-class StampVariated : public virtual StampBase
-{
-  protected:
-     int  min_size;
-     int  max_size;
-  public:
-    virtual int  minSize() override {return min_size;}
-    virtual int  maxSize() override {return max_size;}
-};
-
 class StampUnbounded : public virtual StampBase
 {
   protected:
diff --git a/t/test-chars-stamps.h b/t/test-chars-stamps.h
@@ -48,19 +48,14 @@ StampTwoChars::ExtractStr(Blob &blob)
 }
 
 /*****************************************************************************/
-class StampSeveralChars: public StampVariated, public StampBaseStr
+class StampSeveralChars: public StampBaseStr
 {
   public:
-    StampSeveralChars();
+    virtual int  minSize() override {return 2;} /* Minimal size of consumed data */
+    virtual int  maxSize() override {return 8;} /* Maximal size of consumed data */
     std::string ExtractStr(Blob &blob) override;
 };
 
-StampSeveralChars::StampSeveralChars()
-{
-    min_size = 2;
-    max_size = 8;
-}
-
 std::string
 StampSeveralChars::ExtractStr(Blob &blob)
 {
