hide false positives found by clang analyzer

funbringer · funbringer · commit 6b00d812b939 · 2017-10-12T15:45:04.000+03:00
diff --git a/src/pathman_workers.c b/src/pathman_workers.c
@@ -534,12 +534,14 @@ bgw_main_concurrent_part(Datum main_arg)
 
 			/* Great, now relation is locked */
 			rel_locked = true;
+			(void) rel_locked; /* mute clang analyzer */
 
 			/* Make sure that relation exists */
 			if (!SearchSysCacheExists1(RELOID, ObjectIdGetDatum(part_slot->relid)))
 			{
 				/* Exit after we raise ERROR */
 				failures_count = PART_WORKER_MAX_ATTEMPTS;
+				(void) failures_count; /* mute clang analyzer */
 
 				elog(ERROR, "relation %u does not exist", part_slot->relid);
 			}
@@ -549,6 +551,7 @@ bgw_main_concurrent_part(Datum main_arg)
 			{
 				/* Exit after we raise ERROR */
 				failures_count = PART_WORKER_MAX_ATTEMPTS;
+				(void) failures_count; /* mute clang analyzer */
 
 				elog(ERROR, "relation \"%s\" is not partitioned",
 					 get_rel_name(part_slot->relid));

Original file line number	Diff line number	Diff line change
`@@ -534,12 +534,14 @@ bgw_main_concurrent_part(Datum main_arg)`
`534`	`534`
`535`	`535`	`/* Great, now relation is locked */`
`536`	`536`	`rel_locked = true;`
	`537`	`+ (void) rel_locked; /* mute clang analyzer */`
`537`	`538`
`538`	`539`	`/* Make sure that relation exists */`
`539`	`540`	`if (!SearchSysCacheExists1(RELOID, ObjectIdGetDatum(part_slot->relid)))`
`540`	`541`	`{`
`541`	`542`	`/* Exit after we raise ERROR */`
`542`	`543`	`failures_count = PART_WORKER_MAX_ATTEMPTS;`
	`544`	`+ (void) failures_count; /* mute clang analyzer */`
`543`	`545`
`544`	`546`	`elog(ERROR, "relation %u does not exist", part_slot->relid);`
`545`	`547`	`}`
`@@ -549,6 +551,7 @@ bgw_main_concurrent_part(Datum main_arg)`
`549`	`551`	`{`
`550`	`552`	`/* Exit after we raise ERROR */`
`551`	`553`	`failures_count = PART_WORKER_MAX_ATTEMPTS;`
	`554`	`+ (void) failures_count; /* mute clang analyzer */`
`552`	`555`
`553`	`556`	`elog(ERROR, "relation \"%s\" is not partitioned",`
`554`	`557`	`get_rel_name(part_slot->relid));`