Fix shmem allocation size.

rjuju · rjuju · commit 28f6e20a2644 · 2022-03-25T14:01:39.000+08:00
MaxBackends is still 0 when _PG_init() is called, which means that we
don't request enough memory in RequestAddinShmemSpace(), while the rest of
the code sees (and allocate) a correct value.

It's technically usually not a problem as postgres adds an extra 100kB of
memory for small unaccounted memory usage, but it's better to avoid relying on
it too much.

Note that the value is still not guaranteed to be exact as other modules
_PG_init() could later change the underlying GUCs, but there is not available
API to handle that case accurately.
diff --git a/pg_wait_sampling.c b/pg_wait_sampling.c
@@ -17,6 +17,10 @@
 #include "miscadmin.h"
 #include "optimizer/planner.h"
 #include "pgstat.h"
+#include "postmaster/autovacuum.h"
+#if PG_VERSION_NUM >= 120000
+#include "replication/walsender.h"
+#endif
 #include "storage/ipc.h"
 #include "storage/pg_shmem.h"
 #include "storage/procarray.h"
@@ -75,7 +79,12 @@ get_max_procs_count(void)
 	int count = 0;
 
 	/* MyProcs, including autovacuum workers and launcher */
-	count += MaxBackends;
+	count += MaxConnections + autovacuum_max_workers + 1
+			+ max_worker_processes
+#if PG_VERSION_NUM >= 120000
+			+ max_wal_senders
+#endif
+			+ 1;
 	/* AuxiliaryProcs */
 	count += NUM_AUXILIARY_PROCS;
 	/* Prepared xacts */
