Fix kill() call in elog() so that it gets its own pid by calling getpid().

tatsuo-ishii · tatsuo-ishii · commit 075dc252c7b8 · 1999-04-16T06:38:17.000Z
MyProcPid global variable is set to 0 when postgres starts as a command
(not as a backend daemon). This leads issuing SIGQUIT to the process group,
not the process itself. As a result, parent sh gets core dumped in the
Wisconsin benchmark test.
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
@@ -7,7 +7,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/utils/error/elog.c,v 1.39 1999/02/13 23:19:47 momjian Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/utils/error/elog.c,v 1.40 1999/04/16 06:38:17 ishii Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -221,7 +221,11 @@ elog(int lev, const char *fmt,...)
 		ProcReleaseSpins(NULL); /* get rid of spinlocks we hold */
 		if (!InError)
 		{
-			kill(MyProcPid, SIGQUIT);	/* abort to traffic cop */
+			if (MyProcPid == 0) {
+				kill(getpid(), SIGQUIT);
+			} else {
+				kill(MyProcPid, SIGQUIT);	/* abort to traffic cop */
+			}
 			pause();
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`*`
`8`	`8`	`*`
`9`	`9`	`* IDENTIFICATION`
`10`		`- * $Header: /cvsroot/pgsql/src/backend/utils/error/elog.c,v 1.39 1999/02/13 23:19:47 momjian Exp $`
	`10`	`+ * $Header: /cvsroot/pgsql/src/backend/utils/error/elog.c,v 1.40 1999/04/16 06:38:17 ishii Exp $`
`11`	`11`	`*`
`12`	`12`	`*-------------------------------------------------------------------------`
`13`	`13`	`*/`
`@@ -221,7 +221,11 @@ elog(int lev, const char *fmt,...)`
`221`	`221`	`ProcReleaseSpins(NULL); /* get rid of spinlocks we hold */`
`222`	`222`	`if (!InError)`
`223`	`223`	`{`
`224`		`- kill(MyProcPid, SIGQUIT); /* abort to traffic cop */`
	`224`	`+ if (MyProcPid == 0) {`
	`225`	`+ kill(getpid(), SIGQUIT);`
	`226`	`+ } else {`
	`227`	`+ kill(MyProcPid, SIGQUIT); /* abort to traffic cop */`
	`228`	`+ }`
`225`	`229`	`pause();`
`226`	`230`	`}`
`227`	`231`