equalAttr() had its strcmp test backwards :-(

tglsfdc · tglsfdc · commit 1bd6f76ed65b · 2000-03-01T18:47:43.000Z
diff --git a/src/backend/nodes/equalfuncs.c b/src/backend/nodes/equalfuncs.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/nodes/equalfuncs.c,v 1.63 2000/02/21 18:47:00 tgl Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/nodes/equalfuncs.c,v 1.64 2000/03/01 18:47:43 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -98,7 +98,7 @@ _equalExpr(Expr *a, Expr *b)
 static bool
 _equalAttr(Attr *a, Attr *b)
 {
-	if (!strcmp(a->relname, b->relname))
+	if (strcmp(a->relname, b->relname) != 0)
 		return false;
 	if (!equal(a->attrs, b->attrs))
 		return false;

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $Header: /cvsroot/pgsql/src/backend/nodes/equalfuncs.c,v 1.63 2000/02/21 18:47:00 tgl Exp $`
	`11`	`+ * $Header: /cvsroot/pgsql/src/backend/nodes/equalfuncs.c,v 1.64 2000/03/01 18:47:43 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -98,7 +98,7 @@ _equalExpr(Expr a, Expr b)`
`98`	`98`	`static bool`
`99`	`99`	`_equalAttr(Attr a, Attr b)`
`100`	`100`	`{`
`101`		`- if (!strcmp(a->relname, b->relname))`
	`101`	`+ if (strcmp(a->relname, b->relname) != 0)`
`102`	`102`	`return false;`
`103`	`103`	`if (!equal(a->attrs, b->attrs))`
`104`	`104`	`return false;`