Silence compiler warning about ignored return value. Our comment already

mhagander · mhagander · commit 284491ee714b · 2008-11-20T15:03:39.000Z
clearly stated that we are aware that we're ignoring it.
diff --git a/src/test/regress/pg_regress.c b/src/test/regress/pg_regress.c
@@ -11,7 +11,7 @@
  * Portions Copyright (c) 1996-2008, PostgreSQL Global Development Group
  * Portions Copyright (c) 1994, Regents of the University of California
  *
- * $PostgreSQL: pgsql/src/test/regress/pg_regress.c,v 1.49 2008/11/09 00:28:35 tgl Exp $
+ * $PostgreSQL: pgsql/src/test/regress/pg_regress.c,v 1.50 2008/11/20 15:03:39 mha Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -271,6 +271,7 @@ stop_postmaster(void)
 	{
 		/* We use pg_ctl to issue the kill and wait for stop */
 		char		buf[MAXPGPATH * 2];
+		int			r;
 
 		/* On Windows, system() seems not to force fflush, so... */
 		fflush(stdout);
@@ -279,7 +280,7 @@ stop_postmaster(void)
 		snprintf(buf, sizeof(buf),
 				 SYSTEMQUOTE "\"%s/pg_ctl\" stop -D \"%s/data\" -s -m fast" SYSTEMQUOTE,
 				 bindir, temp_install);
-		system(buf);			/* ignore exit status */
+		r = system(buf);			/* ignore exit status. Store in variable to silence gcc */
 		postmaster_running = false;
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@`
`11`	`11`	`* Portions Copyright (c) 1996-2008, PostgreSQL Global Development Group`
`12`	`12`	`* Portions Copyright (c) 1994, Regents of the University of California`
`13`	`13`	`*`
`14`		`- * $PostgreSQL: pgsql/src/test/regress/pg_regress.c,v 1.49 2008/11/09 00:28:35 tgl Exp $`
	`14`	`+ * $PostgreSQL: pgsql/src/test/regress/pg_regress.c,v 1.50 2008/11/20 15:03:39 mha Exp $`
`15`	`15`	`*`
`16`	`16`	`*-------------------------------------------------------------------------`
`17`	`17`	`*/`
`@@ -271,6 +271,7 @@ stop_postmaster(void)`
`271`	`271`	`{`
`272`	`272`	`/* We use pg_ctl to issue the kill and wait for stop */`
`273`	`273`	`char buf[MAXPGPATH * 2];`
	`274`	`+ int r;`
`274`	`275`
`275`	`276`	`/* On Windows, system() seems not to force fflush, so... */`
`276`	`277`	`fflush(stdout);`
`@@ -279,7 +280,7 @@ stop_postmaster(void)`
`279`	`280`	`snprintf(buf, sizeof(buf),`
`280`	`281`	`SYSTEMQUOTE "\"%s/pg_ctl\" stop -D \"%s/data\" -s -m fast" SYSTEMQUOTE,`
`281`	`282`	`bindir, temp_install);`
`282`		`- system(buf); /* ignore exit status */`
	`283`	`+ r = system(buf); /* ignore exit status. Store in variable to silence gcc */`
`283`	`284`	`postmaster_running = false;`
`284`	`285`	`}`
`285`	`286`	`}`