Avoid losing track of data for shared tables in pgstats. Report by Michael

alvherre · alvherre · commit 2d9d7a6bf568 · 2007-06-07T18:53:17.000Z
Fuhr, patch from Tom Lane after a messier suggestion by me.
diff --git a/src/backend/postmaster/pgstat.c b/src/backend/postmaster/pgstat.c
@@ -13,7 +13,7 @@
  *
  *	Copyright (c) 2001-2007, PostgreSQL Global Development Group
  *
- *	$PostgreSQL: pgsql/src/backend/postmaster/pgstat.c,v 1.158 2007/05/27 17:28:35 tgl Exp $
+ *	$PostgreSQL: pgsql/src/backend/postmaster/pgstat.c,v 1.159 2007/06/07 18:53:17 alvherre Exp $
  * ----------
  */
 #include "postgres.h"
@@ -813,7 +813,9 @@ pgstat_vacuum_tabstat(void)
 
 		CHECK_FOR_INTERRUPTS();
 
-		if (hash_search(htab, (void *) &dbid, HASH_FIND, NULL) == NULL)
+		/* the DB entry for shared tables (with InvalidOid) is never dropped */
+		if (OidIsValid(dbid) &&
+			hash_search(htab, (void *) &dbid, HASH_FIND, NULL) == NULL)
 			pgstat_drop_database(dbid);
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@`
`13`	`13`	`*`
`14`	`14`	`* Copyright (c) 2001-2007, PostgreSQL Global Development Group`
`15`	`15`	`*`
`16`		`- * $PostgreSQL: pgsql/src/backend/postmaster/pgstat.c,v 1.158 2007/05/27 17:28:35 tgl Exp $`
	`16`	`+ * $PostgreSQL: pgsql/src/backend/postmaster/pgstat.c,v 1.159 2007/06/07 18:53:17 alvherre Exp $`
`17`	`17`	`* ----------`
`18`	`18`	`*/`
`19`	`19`	`#include "postgres.h"`
`@@ -813,7 +813,9 @@ pgstat_vacuum_tabstat(void)`
`813`	`813`
`814`	`814`	`CHECK_FOR_INTERRUPTS();`
`815`	`815`
`816`		`- if (hash_search(htab, (void *) &dbid, HASH_FIND, NULL) == NULL)`
	`816`	`+ /* the DB entry for shared tables (with InvalidOid) is never dropped */`
	`817`	`+ if (OidIsValid(dbid) &&`
	`818`	`+ hash_search(htab, (void *) &dbid, HASH_FIND, NULL) == NULL)`
`817`	`819`	`pgstat_drop_database(dbid);`
`818`	`820`	`}`
`819`	`821`