Pass sensible value to memset() when randomizing reorderbuffer's tuple slab.

hlinnaka · hlinnaka · commit 377790fbd707 · 2014-05-05T16:22:15.000+03:00
This is entirely harmless, but still wrong. Noticed by coverity.

Andres Freund
diff --git a/src/backend/replication/logical/reorderbuffer.c b/src/backend/replication/logical/reorderbuffer.c
@@ -456,7 +456,7 @@ ReorderBufferGetTupleBuf(ReorderBuffer *rb)
 		tuple = slist_container(ReorderBufferTupleBuf, node,
 								slist_pop_head_node(&rb->cached_tuplebufs));
 #ifdef USE_ASSERT_CHECKING
-		memset(tuple, 0xdeadbeef, sizeof(ReorderBufferTupleBuf));
+		memset(tuple, 0xa9, sizeof(ReorderBufferTupleBuf));
 #endif
 	}
 	else

Original file line number	Diff line number	Diff line change
`@@ -456,7 +456,7 @@ ReorderBufferGetTupleBuf(ReorderBuffer *rb)`
`456`	`456`	`tuple = slist_container(ReorderBufferTupleBuf, node,`
`457`	`457`	`slist_pop_head_node(&rb->cached_tuplebufs));`
`458`	`458`	`#ifdef USE_ASSERT_CHECKING`
`459`		`- memset(tuple, 0xdeadbeef, sizeof(ReorderBufferTupleBuf));`
	`459`	`+ memset(tuple, 0xa9, sizeof(ReorderBufferTupleBuf));`
`460`	`460`	`#endif`
`461`	`461`	`}`
`462`	`462`	`else`