When setting default thousands separator when locale has "", use logic

bmomjian · bmomjian · commit 3894e7cc55c0 · 2007-11-21T22:28:18.000Z
so new thousands separator doesn't match decimal symbol.
diff --git a/src/backend/utils/adt/formatting.c b/src/backend/utils/adt/formatting.c
@@ -1,7 +1,7 @@
 /* -----------------------------------------------------------------------
  * formatting.c
  *
- * $PostgreSQL: pgsql/src/backend/utils/adt/formatting.c,v 1.133 2007/11/21 21:49:22 momjian Exp $
+ * $PostgreSQL: pgsql/src/backend/utils/adt/formatting.c,v 1.134 2007/11/21 22:28:18 momjian Exp $
  *
  *
  *	 Portions Copyright (c) 1999-2007, PostgreSQL Global Development Group
@@ -3915,7 +3915,6 @@ NUM_prepare_locale(NUMProc *Np)
 		 */
 		if (lconv->decimal_point && *lconv->decimal_point)
 			Np->decimal = lconv->decimal_point;
-
 		else
 			Np->decimal = ".";
 
@@ -3926,13 +3925,14 @@ NUM_prepare_locale(NUMProc *Np)
 		 * Number thousands separator
 		 *
 		 * Some locales (e.g. broken glibc pt_BR), have a comma for decimal,
-		 * but "" for thousands_sep, so we make the thousands_sep comma
-		 * too.  2007-02-12
+		 * but "" for thousands_sep, so we set the thousands_sep too. 2007-02-12
 		 */
 		if (lconv->thousands_sep && *lconv->thousands_sep)
 			Np->L_thousands_sep = lconv->thousands_sep;
-		else
+		else if (strcmp(Np->decimal, ",") != 0)
 			Np->L_thousands_sep = ",";
+		else
+			Np->L_thousands_sep = ".";
 
 		/*
 		 * Currency symbol
diff --git a/src/bin/psql/print.c b/src/bin/psql/print.c
@@ -3,7 +3,7 @@
  *
  * Copyright (c) 2000-2007, PostgreSQL Global Development Group
  *
- * $PostgreSQL: pgsql/src/bin/psql/print.c,v 1.91 2007/01/05 22:19:49 momjian Exp $
+ * $PostgreSQL: pgsql/src/bin/psql/print.c,v 1.92 2007/11/21 22:28:18 momjian Exp $
  *
  * Note: we include postgres.h not postgres_fe.h so that we can include
  * catalog/pg_type.h, and thereby have access to INT4OID and similar macros.
@@ -2039,7 +2039,7 @@ setDecimalLocale(void)
 		grouping = "3";			/* most common */
 	if (*extlconv->thousands_sep)
 		thousands_sep = strdup(extlconv->thousands_sep);
-	else if (*decimal_point != ',')
+	else if (strcmp(decimal_point, ",") != 0)
 		thousands_sep = ",";
 	else
 		thousands_sep = ".";

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@`
`3`	`3`	`*`
`4`	`4`	`* Copyright (c) 2000-2007, PostgreSQL Global Development Group`
`5`	`5`	`*`
`6`		`- * $PostgreSQL: pgsql/src/bin/psql/print.c,v 1.91 2007/01/05 22:19:49 momjian Exp $`
	`6`	`+ * $PostgreSQL: pgsql/src/bin/psql/print.c,v 1.92 2007/11/21 22:28:18 momjian Exp $`
`7`	`7`	`*`
`8`	`8`	`* Note: we include postgres.h not postgres_fe.h so that we can include`
`9`	`9`	`* catalog/pg_type.h, and thereby have access to INT4OID and similar macros.`
`@@ -2039,7 +2039,7 @@ setDecimalLocale(void)`
`2039`	`2039`	`grouping = "3"; /* most common */`
`2040`	`2040`	`if (*extlconv->thousands_sep)`
`2041`	`2041`	`thousands_sep = strdup(extlconv->thousands_sep);`
`2042`		`- else if (*decimal_point != ',')`
	`2042`	`+ else if (strcmp(decimal_point, ",") != 0)`
`2043`	`2043`	`thousands_sep = ",";`
`2044`	`2044`	`else`
`2045`	`2045`	`thousands_sep = ".";`