Fix IsBinaryCoercible to not confuse a cast using in/out functions

hlinnaka · hlinnaka · commit 3bdede397456 · 2010-03-04T09:39:53.000Z
with binary compatibility.

Backpatch to 8.4 where INOUT casts were introduced.
diff --git a/src/backend/parser/parse_coerce.c b/src/backend/parser/parse_coerce.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/parser/parse_coerce.c,v 2.181 2010/02/26 02:00:52 momjian Exp $
+ *	  $PostgreSQL: pgsql/src/backend/parser/parse_coerce.c,v 2.182 2010/03/04 09:39:53 heikki Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -1792,7 +1792,7 @@ IsBinaryCoercible(Oid srctype, Oid targettype)
 		return false;			/* no cast */
 	castForm = (Form_pg_cast) GETSTRUCT(tuple);
 
-	result = (castForm->castfunc == InvalidOid &&
+	result = (castForm->castmethod == COERCION_METHOD_BINARY &&
 			  castForm->castcontext == COERCION_CODE_IMPLICIT);
 
 	ReleaseSysCache(tuple);

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/backend/parser/parse_coerce.c,v 2.181 2010/02/26 02:00:52 momjian Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/backend/parser/parse_coerce.c,v 2.182 2010/03/04 09:39:53 heikki Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -1792,7 +1792,7 @@ IsBinaryCoercible(Oid srctype, Oid targettype)`
`1792`	`1792`	`return false; /* no cast */`
`1793`	`1793`	`castForm = (Form_pg_cast) GETSTRUCT(tuple);`
`1794`	`1794`
`1795`		`- result = (castForm->castfunc == InvalidOid &&`
	`1795`	`+ result = (castForm->castmethod == COERCION_METHOD_BINARY &&`
`1796`	`1796`	`castForm->castcontext == COERCION_CODE_IMPLICIT);`
`1797`	`1797`
`1798`	`1798`	`ReleaseSysCache(tuple);`