Silence Coverity warnings about unused return values from pushJsonbValue()

hlinnaka · hlinnaka · commit 4ebb3494e9e0 · 2015-01-13T16:01:04.000+02:00
Similar warnings from backend were silenced earlier by commit c831593, but there were a few more contrib/hstore. Michael Paquier
diff --git a/contrib/hstore/hstore_io.c b/contrib/hstore/hstore_io.c
@@ -1338,7 +1338,7 @@ hstore_to_jsonb(PG_FUNCTION_ARGS)
 	JsonbParseState *state = NULL;
 	JsonbValue *res;
 
-	res = pushJsonbValue(&state, WJB_BEGIN_OBJECT, NULL);
+	(void) pushJsonbValue(&state, WJB_BEGIN_OBJECT, NULL);
 
 	for (i = 0; i < count; i++)
 	{
@@ -1349,7 +1349,7 @@ hstore_to_jsonb(PG_FUNCTION_ARGS)
 		key.val.string.len = HS_KEYLEN(entries, i);
 		key.val.string.val = HS_KEY(entries, base, i);
 
-		res = pushJsonbValue(&state, WJB_KEY, &key);
+		(void) pushJsonbValue(&state, WJB_KEY, &key);
 
 		if (HS_VALISNULL(entries, i))
 		{
@@ -1361,7 +1361,7 @@ hstore_to_jsonb(PG_FUNCTION_ARGS)
 			val.val.string.len = HS_VALLEN(entries, i);
 			val.val.string.val = HS_VAL(entries, base, i);
 		}
-		res = pushJsonbValue(&state, WJB_VALUE, &val);
+		(void) pushJsonbValue(&state, WJB_VALUE, &val);
 	}
 
 	res = pushJsonbValue(&state, WJB_END_OBJECT, NULL);
@@ -1385,7 +1385,7 @@ hstore_to_jsonb_loose(PG_FUNCTION_ARGS)
 
 	initStringInfo(&tmp);
 
-	res = pushJsonbValue(&state, WJB_BEGIN_OBJECT, NULL);
+	(void) pushJsonbValue(&state, WJB_BEGIN_OBJECT, NULL);
 
 	for (i = 0; i < count; i++)
 	{
@@ -1396,7 +1396,7 @@ hstore_to_jsonb_loose(PG_FUNCTION_ARGS)
 		key.val.string.len = HS_KEYLEN(entries, i);
 		key.val.string.val = HS_KEY(entries, base, i);
 
-		res = pushJsonbValue(&state, WJB_KEY, &key);
+		(void) pushJsonbValue(&state, WJB_KEY, &key);
 
 		if (HS_VALISNULL(entries, i))
 		{
@@ -1471,7 +1471,7 @@ hstore_to_jsonb_loose(PG_FUNCTION_ARGS)
 				val.val.string.val = HS_VAL(entries, base, i);
 			}
 		}
-		res = pushJsonbValue(&state, WJB_VALUE, &val);
+		(void) pushJsonbValue(&state, WJB_VALUE, &val);
 	}
 
 	res = pushJsonbValue(&state, WJB_END_OBJECT, NULL);

Original file line number	Diff line number	Diff line change
`@@ -1338,7 +1338,7 @@ hstore_to_jsonb(PG_FUNCTION_ARGS)`
`1338`	`1338`	`JsonbParseState *state = NULL;`
`1339`	`1339`	`JsonbValue *res;`
`1340`	`1340`
`1341`		`- res = pushJsonbValue(&state, WJB_BEGIN_OBJECT, NULL);`
	`1341`	`+ (void) pushJsonbValue(&state, WJB_BEGIN_OBJECT, NULL);`
`1342`	`1342`
`1343`	`1343`	`for (i = 0; i < count; i++)`
`1344`	`1344`	`{`
`@@ -1349,7 +1349,7 @@ hstore_to_jsonb(PG_FUNCTION_ARGS)`
`1349`	`1349`	`key.val.string.len = HS_KEYLEN(entries, i);`
`1350`	`1350`	`key.val.string.val = HS_KEY(entries, base, i);`
`1351`	`1351`
`1352`		`- res = pushJsonbValue(&state, WJB_KEY, &key);`
	`1352`	`+ (void) pushJsonbValue(&state, WJB_KEY, &key);`
`1353`	`1353`
`1354`	`1354`	`if (HS_VALISNULL(entries, i))`
`1355`	`1355`	`{`
`@@ -1361,7 +1361,7 @@ hstore_to_jsonb(PG_FUNCTION_ARGS)`
`1361`	`1361`	`val.val.string.len = HS_VALLEN(entries, i);`
`1362`	`1362`	`val.val.string.val = HS_VAL(entries, base, i);`
`1363`	`1363`	`}`
`1364`		`- res = pushJsonbValue(&state, WJB_VALUE, &val);`
	`1364`	`+ (void) pushJsonbValue(&state, WJB_VALUE, &val);`
`1365`	`1365`	`}`
`1366`	`1366`
`1367`	`1367`	`res = pushJsonbValue(&state, WJB_END_OBJECT, NULL);`
`@@ -1385,7 +1385,7 @@ hstore_to_jsonb_loose(PG_FUNCTION_ARGS)`
`1385`	`1385`
`1386`	`1386`	`initStringInfo(&tmp);`
`1387`	`1387`
`1388`		`- res = pushJsonbValue(&state, WJB_BEGIN_OBJECT, NULL);`
	`1388`	`+ (void) pushJsonbValue(&state, WJB_BEGIN_OBJECT, NULL);`
`1389`	`1389`
`1390`	`1390`	`for (i = 0; i < count; i++)`
`1391`	`1391`	`{`
`@@ -1396,7 +1396,7 @@ hstore_to_jsonb_loose(PG_FUNCTION_ARGS)`
`1396`	`1396`	`key.val.string.len = HS_KEYLEN(entries, i);`
`1397`	`1397`	`key.val.string.val = HS_KEY(entries, base, i);`
`1398`	`1398`
`1399`		`- res = pushJsonbValue(&state, WJB_KEY, &key);`
	`1399`	`+ (void) pushJsonbValue(&state, WJB_KEY, &key);`
`1400`	`1400`
`1401`	`1401`	`if (HS_VALISNULL(entries, i))`
`1402`	`1402`	`{`
`@@ -1471,7 +1471,7 @@ hstore_to_jsonb_loose(PG_FUNCTION_ARGS)`
`1471`	`1471`	`val.val.string.val = HS_VAL(entries, base, i);`
`1472`	`1472`	`}`
`1473`	`1473`	`}`
`1474`		`- res = pushJsonbValue(&state, WJB_VALUE, &val);`
	`1474`	`+ (void) pushJsonbValue(&state, WJB_VALUE, &val);`
`1475`	`1475`	`}`
`1476`	`1476`
`1477`	`1477`	`res = pushJsonbValue(&state, WJB_END_OBJECT, NULL);`