pg_upgrade: no need to check for matching float8_pass_by_value

bmomjian · bmomjian · commit 750ccaef2964 · 2015-05-16T15:27:14.000-04:00
Report by Noah Misch
diff --git a/src/bin/pg_upgrade/controldata.c b/src/bin/pg_upgrade/controldata.c
@@ -564,8 +564,7 @@ check_control_data(ControlData *oldctrl,
 	if (oldctrl->date_is_int != newctrl->date_is_int)
 		pg_fatal("old and new pg_controldata date/time storage types do not match\n");
 
-	if (oldctrl->float8_pass_by_value != newctrl->float8_pass_by_value)
-		pg_fatal("old and new pg_controldata float8 argument passing methods do not match\n");
+	/* float8_pass_by_value does not need to match */
 
 	/*
 	 * We might eventually allow upgrades from checksum to no-checksum
