Reduce the acceptable staleness of pgstat data for autovacuum, per the

alvherre · alvherre · commit 88dd4b0a0d3d · 2008-11-03T19:03:41.000Z
longstanding note in the source that this patch removes.
diff --git a/src/backend/postmaster/autovacuum.c b/src/backend/postmaster/autovacuum.c
@@ -55,7 +55,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/postmaster/autovacuum.c,v 1.85 2008/11/02 21:24:52 tgl Exp $
+ *	  $PostgreSQL: pgsql/src/backend/postmaster/autovacuum.c,v 1.86 2008/11/03 19:03:41 alvherre Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -2149,8 +2149,10 @@ do_autovacuum(void)
 		 * It could have changed if something else processed the table while
 		 * we weren't looking.
 		 *
-		 * FIXME we ignore the possibility that the table was finished being
-		 * vacuumed in the last 500ms (PGSTAT_STAT_INTERVAL).  This is a bug.
+		 * Note: we have a special case in pgstat code to ensure that the stats
+		 * we read are as up-to-date as possible, to avoid the problem that
+		 * somebody just finished vacuuming this table.  The window to the race
+		 * condition is not closed but it is very small.
 		 */
 		MemoryContextSwitchTo(AutovacMemCxt);
 		tab = table_recheck_autovac(relid, table_toast_map);
diff --git a/src/backend/postmaster/pgstat.c b/src/backend/postmaster/pgstat.c
@@ -13,7 +13,7 @@
  *
  *	Copyright (c) 2001-2008, PostgreSQL Global Development Group
  *
- *	$PostgreSQL: pgsql/src/backend/postmaster/pgstat.c,v 1.182 2008/11/03 01:17:08 tgl Exp $
+ *	$PostgreSQL: pgsql/src/backend/postmaster/pgstat.c,v 1.183 2008/11/03 19:03:41 alvherre Exp $
  * ----------
  */
 #include "postgres.h"
@@ -3381,16 +3381,23 @@ backend_read_statsfile(void)
 	/*
 	 * We set the minimum acceptable timestamp to PGSTAT_STAT_INTERVAL msec
 	 * before now.  This indirectly ensures that the collector needn't write
-	 * the file more often than PGSTAT_STAT_INTERVAL.
+	 * the file more often than PGSTAT_STAT_INTERVAL.  In an autovacuum
+	 * worker, however, we want a lower delay to avoid using stale data, so we
+	 * use PGSTAT_RETRY_DELAY (since the number of worker is low, this
+	 * shouldn't be a problem).
 	 *
 	 * Note that we don't recompute min_ts after sleeping; so we might end up
 	 * accepting a file a bit older than PGSTAT_STAT_INTERVAL.  In practice
 	 * that shouldn't happen, though, as long as the sleep time is less than
 	 * PGSTAT_STAT_INTERVAL; and we don't want to lie to the collector about
 	 * what our cutoff time really is.
 	 */
-	min_ts = TimestampTzPlusMilliseconds(GetCurrentTimestamp(),
-										 -PGSTAT_STAT_INTERVAL);
+	if (IsAutoVacuumWorkerProcess())
+		min_ts = TimestampTzPlusMilliseconds(GetCurrentTimestamp(),
+											 -PGSTAT_RETRY_DELAY);
+	else
+		min_ts = TimestampTzPlusMilliseconds(GetCurrentTimestamp(),
+											 -PGSTAT_STAT_INTERVAL);
 
 	/*
 	 * Loop until fresh enough stats file is available or we ran out of time.

Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@`
`55`	`55`	`*`
`56`	`56`	`*`
`57`	`57`	`* IDENTIFICATION`
`58`		`- * $PostgreSQL: pgsql/src/backend/postmaster/autovacuum.c,v 1.85 2008/11/02 21:24:52 tgl Exp $`
	`58`	`+ * $PostgreSQL: pgsql/src/backend/postmaster/autovacuum.c,v 1.86 2008/11/03 19:03:41 alvherre Exp $`
`59`	`59`	`*`
`60`	`60`	`*-------------------------------------------------------------------------`
`61`	`61`	`*/`
`@@ -2149,8 +2149,10 @@ do_autovacuum(void)`
`2149`	`2149`	`* It could have changed if something else processed the table while`
`2150`	`2150`	`* we weren't looking.`
`2151`	`2151`	`*`
`2152`		`- * FIXME we ignore the possibility that the table was finished being`
`2153`		`- * vacuumed in the last 500ms (PGSTAT_STAT_INTERVAL). This is a bug.`
	`2152`	`+ * Note: we have a special case in pgstat code to ensure that the stats`
	`2153`	`+ * we read are as up-to-date as possible, to avoid the problem that`
	`2154`	`+ * somebody just finished vacuuming this table. The window to the race`
	`2155`	`+ * condition is not closed but it is very small.`
`2154`	`2156`	`*/`
`2155`	`2157`	`MemoryContextSwitchTo(AutovacMemCxt);`
`2156`	`2158`	`tab = table_recheck_autovac(relid, table_toast_map);`