Report libpq errors correctly if session setup or teardown steps fail in

hlinnaka · hlinnaka · commit b936d9264c08 · 2011-08-18T16:47:31.000+03:00
isolation regression tests.

Alvaro committed these fixes to master branch on Tue Jul 29th, as part of
Noah Misch's patch. The rest of that patch is not needed on 9.1, but this
part should be backpatched.
diff --git a/src/test/isolation/isolationtester.c b/src/test/isolation/isolationtester.c
@@ -286,7 +286,7 @@ run_permutation(TestSpec * testspec, int nsteps, Step ** steps)
 			{
 				fprintf(stderr, "setup of session %s failed: %s",
 						testspec->sessions[i]->name,
-						PQerrorMessage(conns[0]));
+						PQerrorMessage(conns[i]));
 				exit_nicely();
 			}
 			PQclear(res);
@@ -333,7 +333,7 @@ run_permutation(TestSpec * testspec, int nsteps, Step ** steps)
 			{
 				fprintf(stderr, "teardown of session %s failed: %s",
 						testspec->sessions[i]->name,
-						PQerrorMessage(conns[0]));
+						PQerrorMessage(conns[i]));
 				/* don't exit on teardown failure */
 			}
 			PQclear(res);

Original file line number	Diff line number	Diff line change
`@@ -286,7 +286,7 @@ run_permutation(TestSpec * testspec, int nsteps, Step ** steps)`
`286`	`286`	`{`
`287`	`287`	`fprintf(stderr, "setup of session %s failed: %s",`
`288`	`288`	`testspec->sessions[i]->name,`
`289`		`- PQerrorMessage(conns[0]));`
	`289`	`+ PQerrorMessage(conns[i]));`
`290`	`290`	`exit_nicely();`
`291`	`291`	`}`
`292`	`292`	`PQclear(res);`
`@@ -333,7 +333,7 @@ run_permutation(TestSpec * testspec, int nsteps, Step ** steps)`
`333`	`333`	`{`
`334`	`334`	`fprintf(stderr, "teardown of session %s failed: %s",`
`335`	`335`	`testspec->sessions[i]->name,`
`336`		`- PQerrorMessage(conns[0]));`
	`336`	`+ PQerrorMessage(conns[i]));`
`337`	`337`	`/* don't exit on teardown failure */`
`338`	`338`	`}`
`339`	`339`	`PQclear(res);`