Tweak select_common_type() to deal with possibility of multiple preferred

tglsfdc · tglsfdc · commit cfa4d4d040ba · 2000-12-17T04:32:29.000Z
types in a category --- it was taking the last preferred type among the
inputs, rather than the first one as intended.
diff --git a/src/backend/parser/parse_coerce.c b/src/backend/parser/parse_coerce.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/parser/parse_coerce.c,v 2.51 2000/12/15 18:02:47 tgl Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/parser/parse_coerce.c,v 2.52 2000/12/17 04:32:29 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -364,6 +364,7 @@ select_common_type(List *typeids, const char *context)
 					 context, typeidTypeName(ptype), typeidTypeName(ntype));
 			}
 			else if (IsPreferredType(pcategory, ntype)
+					 && !IsPreferredType(pcategory, ptype)
 					 && can_coerce_type(1, &ptype, &ntype))
 			{
 				/*

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $Header: /cvsroot/pgsql/src/backend/parser/parse_coerce.c,v 2.51 2000/12/15 18:02:47 tgl Exp $`
	`11`	`+ * $Header: /cvsroot/pgsql/src/backend/parser/parse_coerce.c,v 2.52 2000/12/17 04:32:29 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -364,6 +364,7 @@ select_common_type(List typeids, const char context)`
`364`	`364`	`context, typeidTypeName(ptype), typeidTypeName(ntype));`
`365`	`365`	`}`
`366`	`366`	`else if (IsPreferredType(pcategory, ntype)`
	`367`	`+ && !IsPreferredType(pcategory, ptype)`
`367`	`368`	`&& can_coerce_type(1, &ptype, &ntype))`
`368`	`369`	`{`
`369`	`370`	`/*`