Now that the shared library name can be adjusted in the library test,

bmomjian · bmomjian · commit e96fcb06b972 · 2012-01-25T09:35:17.000-05:00
have pg_upgrade allocate a maximum fixed size buffer for testing the
library file name, rather than base the allocation on the library name.

Backpatch to 9.1.
diff --git a/contrib/pg_upgrade/function.c b/contrib/pg_upgrade/function.c
@@ -224,7 +224,7 @@ check_loadable_libraries(void)
 	{
 		char	   *lib = os_info.libraries[libnum];
 		int			llen = strlen(lib);
-		char	   *cmd = (char *) pg_malloc(8 + 2 * llen + 1);
+		char		cmd[7 + 2 * MAXPGPATH + 1];
 		PGresult   *res;
 
 		/*
@@ -261,7 +261,6 @@ check_loadable_libraries(void)
 		}
 
 		PQclear(res);
-		pg_free(cmd);
 	}
 
 	PQfinish(conn);

Original file line number	Diff line number	Diff line change
`@@ -224,7 +224,7 @@ check_loadable_libraries(void)`
`224`	`224`	`{`
`225`	`225`	`char *lib = os_info.libraries[libnum];`
`226`	`226`	`int llen = strlen(lib);`
`227`		`- char cmd = (char ) pg_malloc(8 + 2 * llen + 1);`
	`227`	`+ char cmd[7 + 2 * MAXPGPATH + 1];`
`228`	`228`	`PGresult *res;`
`229`	`229`
`230`	`230`	`/*`
`@@ -261,7 +261,6 @@ check_loadable_libraries(void)`
`261`	`261`	`}`
`262`	`262`
`263`	`263`	`PQclear(res);`
`264`		`- pg_free(cmd);`
`265`	`264`	`}`
`266`	`265`
`267`	`266`	`PQfinish(conn);`