Fix erroneous replay of GIN_UPDATE_META_PAGE WAL records.

tglsfdc · tglsfdc · commit eacff260fd22 · 2011-11-25T13:59:11.000-05:00
A simple thinko in ginRedoUpdateMetapage, namely failing to increment a
loop counter, led to inserting records into the last pending-list page in
the wrong order (the opposite of that intended).  So far as I can tell,
this would not upset the code that eventually flushes pending items into
the main part of the GIN index.  But it did break the code that searched
the pending list for matches, resulting in transient failure to find
matching entries during index lookups, as illustrated in bug #6307 from
Maksym Boguk.

Back-patch to 8.4 where the incorrect code was introduced.
diff --git a/src/backend/access/gin/ginxlog.c b/src/backend/access/gin/ginxlog.c
@@ -529,6 +529,8 @@ ginRedoUpdateMetapage(XLogRecPtr lsn, XLogRecord *record)
 							elog(ERROR, "failed to add item to index page");
 
 						tuples = (IndexTuple) (((char *) tuples) + tupsize);
+
+						off++;
 					}
 
 					/*

Original file line number	Diff line number	Diff line change
`@@ -529,6 +529,8 @@ ginRedoUpdateMetapage(XLogRecPtr lsn, XLogRecord *record)`
`529`	`529`	`elog(ERROR, "failed to add item to index page");`
`530`	`530`
`531`	`531`	`tuples = (IndexTuple) (((char *) tuples) + tupsize);`
	`532`	`+`
	`533`	`+ off++;`
`532`	`534`	`}`
`533`	`535`
`534`	`536`	`/*`