The code to unlink dropped relations in FinishPreparedTransaction() was

hlinnaka · hlinnaka · commit ebaa1952f1f2 · 2009-06-25T19:05:52.000Z
acting like runs inside WAL recovery, but it doesn't. I must've copy-pasted
this from a redo-function in the relation forks patch. Noticed by Tom Lane
while he was looking through callers of smgrdounlink().
diff --git a/src/backend/access/transam/twophase.c b/src/backend/access/transam/twophase.c
@@ -7,7 +7,7 @@
  * Portions Copyright (c) 1994, Regents of the University of California
  *
  * IDENTIFICATION
- *		$PostgreSQL: pgsql/src/backend/access/transam/twophase.c,v 1.53 2009/06/11 14:48:54 momjian Exp $
+ *		$PostgreSQL: pgsql/src/backend/access/transam/twophase.c,v 1.54 2009/06/25 19:05:52 heikki Exp $
  *
  * NOTES
  *		Each global transaction is associated with a global transaction
@@ -1241,10 +1241,7 @@ FinishPreparedTransaction(const char *gid, bool isCommit)
 		for (fork = 0; fork <= MAX_FORKNUM; fork++)
 		{
 			if (smgrexists(srel, fork))
-			{
-				XLogDropRelation(delrels[i], fork);
-				smgrdounlink(srel, fork, false, true);
-			}
+				smgrdounlink(srel, fork, false, false);
 		}
 		smgrclose(srel);
 	}

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`* Portions Copyright (c) 1994, Regents of the University of California`
`8`	`8`	`*`
`9`	`9`	`* IDENTIFICATION`
`10`		`- * $PostgreSQL: pgsql/src/backend/access/transam/twophase.c,v 1.53 2009/06/11 14:48:54 momjian Exp $`
	`10`	`+ * $PostgreSQL: pgsql/src/backend/access/transam/twophase.c,v 1.54 2009/06/25 19:05:52 heikki Exp $`
`11`	`11`	`*`
`12`	`12`	`* NOTES`
`13`	`13`	`* Each global transaction is associated with a global transaction`
`@@ -1241,10 +1241,7 @@ FinishPreparedTransaction(const char *gid, bool isCommit)`
`1241`	`1241`	`for (fork = 0; fork <= MAX_FORKNUM; fork++)`
`1242`	`1242`	`{`
`1243`	`1243`	`if (smgrexists(srel, fork))`
`1244`		`- {`
`1245`		`- XLogDropRelation(delrels[i], fork);`
`1246`		`- smgrdounlink(srel, fork, false, true);`
`1247`		`- }`
	`1244`	`+ smgrdounlink(srel, fork, false, false);`
`1248`	`1245`	`}`
`1249`	`1246`	`smgrclose(srel);`
`1250`	`1247`	`}`