Cancel pending fsync requests during WAL replay of DROP DATABASE, per bug

tglsfdc · tglsfdc · commit ebb6bae539e1 · 2007-04-12T15:04:35.000Z
report from David Darville.  Back-patch as far as 8.1, which may or may not
have the problem but it seems a safe change anyway.
diff --git a/src/backend/commands/dbcommands.c b/src/backend/commands/dbcommands.c
@@ -13,7 +13,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/commands/dbcommands.c,v 1.193 2007/03/13 00:33:39 tgl Exp $
+ *	  $PostgreSQL: pgsql/src/backend/commands/dbcommands.c,v 1.194 2007/04/12 15:04:35 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -1439,6 +1439,9 @@ dbase_redo(XLogRecPtr lsn, XLogRecord *record)
 		/* Also, clean out any entries in the shared free space map */
 		FreeSpaceMapForgetDatabase(xlrec->db_id);
 
+		/* Also, clean out any fsync requests that might be pending in md.c */
+		ForgetDatabaseFsyncRequests(xlrec->db_id);
+
 		/* Clean out the xlog relcache too */
 		XLogDropDatabase(xlrec->db_id);
 

Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@`
`13`	`13`	`*`
`14`	`14`	`*`
`15`	`15`	`* IDENTIFICATION`
`16`		`- * $PostgreSQL: pgsql/src/backend/commands/dbcommands.c,v 1.193 2007/03/13 00:33:39 tgl Exp $`
	`16`	`+ * $PostgreSQL: pgsql/src/backend/commands/dbcommands.c,v 1.194 2007/04/12 15:04:35 tgl Exp $`
`17`	`17`	`*`
`18`	`18`	`*-------------------------------------------------------------------------`
`19`	`19`	`*/`
`@@ -1439,6 +1439,9 @@ dbase_redo(XLogRecPtr lsn, XLogRecord *record)`
`1439`	`1439`	`/* Also, clean out any entries in the shared free space map */`
`1440`	`1440`	`FreeSpaceMapForgetDatabase(xlrec->db_id);`
`1441`	`1441`
	`1442`	`+ /* Also, clean out any fsync requests that might be pending in md.c */`
	`1443`	`+ ForgetDatabaseFsyncRequests(xlrec->db_id);`
	`1444`	`+`
`1442`	`1445`	`/* Clean out the xlog relcache too */`
`1443`	`1446`	`XLogDropDatabase(xlrec->db_id);`
`1444`	`1447`