Forbid REVOKE on untrusted languages, and don't dump privileges of

petere · petere · commit f39748a70f87 · 2003-12-19T14:21:56.000Z
untrusted languages (in case they sneak in).
diff --git a/src/backend/catalog/aclchk.c b/src/backend/catalog/aclchk.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/catalog/aclchk.c,v 1.95 2003/11/29 19:51:42 pgsql Exp $
+ *	  $PostgreSQL: pgsql/src/backend/catalog/aclchk.c,v 1.96 2003/12/19 14:21:56 petere Exp $
  *
  * NOTES
  *	  See acl.h.
@@ -594,7 +594,7 @@ ExecuteGrantStmt_Language(GrantStmt *stmt)
 			aclcheck_error(ACLCHECK_NO_PRIV, ACL_KIND_LANGUAGE,
 						   NameStr(pg_language_tuple->lanname));
 
-		if (!pg_language_tuple->lanpltrusted && stmt->is_grant)
+		if (!pg_language_tuple->lanpltrusted)
 			ereport(ERROR,
 					(errcode(ERRCODE_WRONG_OBJECT_TYPE),
 					 errmsg("language \"%s\" is not trusted", langname)));
diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
@@ -12,7 +12,7 @@
  *	by PostgreSQL
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/bin/pg_dump/pg_dump.c,v 1.360 2003/12/06 03:00:12 tgl Exp $
+ *	  $PostgreSQL: pgsql/src/bin/pg_dump/pg_dump.c,v 1.361 2003/12/19 14:21:56 petere Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -4633,10 +4633,11 @@ dumpProcLang(Archive *fout, ProcLangInfo *plang)
 				NULL, "",
 				plang->dobj.catId, 0, plang->dobj.dumpId);
 
-	dumpACL(fout, plang->dobj.catId, plang->dobj.dumpId, "LANGUAGE",
-			qlanname, plang->lanname,
-			funcInfo->pronamespace->nspname,
-			NULL, plang->lanacl);
+	if (plang->lanpltrusted)
+		dumpACL(fout, plang->dobj.catId, plang->dobj.dumpId, "LANGUAGE",
+				qlanname, plang->lanname,
+				funcInfo->pronamespace->nspname,
+				NULL, plang->lanacl);
 
 	free(qlanname);
 

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/backend/catalog/aclchk.c,v 1.95 2003/11/29 19:51:42 pgsql Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/backend/catalog/aclchk.c,v 1.96 2003/12/19 14:21:56 petere Exp $`
`12`	`12`	`*`
`13`	`13`	`* NOTES`
`14`	`14`	`* See acl.h.`
`@@ -594,7 +594,7 @@ ExecuteGrantStmt_Language(GrantStmt *stmt)`
`594`	`594`	`aclcheck_error(ACLCHECK_NO_PRIV, ACL_KIND_LANGUAGE,`
`595`	`595`	`NameStr(pg_language_tuple->lanname));`
`596`	`596`
`597`		`- if (!pg_language_tuple->lanpltrusted && stmt->is_grant)`
	`597`	`+ if (!pg_language_tuple->lanpltrusted)`
`598`	`598`	`ereport(ERROR,`
`599`	`599`	`(errcode(ERRCODE_WRONG_OBJECT_TYPE),`
`600`	`600`	`errmsg("language \"%s\" is not trusted", langname)));`